tests: Introduce test/run script for Cockpit
#12368
Conversation
marusak
added
the
no-test
|
Since it became rather simple, I wrote it in shell in the end. |
test/run
Outdated
| # arguments but with an appropriate $TEST_OS, and optionally $TEST_SCENARIO | ||
|
|
||
| # Prepare image | ||
| if [[ $TEST_SCENARIO == container* ]]; then |
There was a problem hiding this comment.
This is a bashism. Either use #!/bin/bash or use POSIX shell ([ "${TEST_SCENARIO#container}" != "$TEST_SCENARIO" ]). But let's just move these into the case loop where you already pattern-match the scenario. Then you have all necessary commands (prepare and run) in one place, which is also easier to follow. Then $TEST_SCENARIO will also always have a value, so that set -u will work.
test/run
Outdated
| @@ -0,0 +1,32 @@ | |||
| #!/bin/sh -e | |||
There was a problem hiding this comment.
Please drop the -e here and add set -eu instead. That way, if you try to call this script like bash test/run for some reason, the options still apply. (Not that relevant here, but it's a good pattern to get used to).
The -u will also assert our assumptions about $TEST_OS always being set.
| ;; | ||
| container-*) | ||
| test/containers/run-tests --container ${TEST_SCENARIO#*-} | ||
| ;; |
There was a problem hiding this comment.
Please add a *) default here with an error message.
External projects use this script to run tests. Let's do the same in Cockpit so `tests/invoke` does not have to differentiate between cockpit and external projects. This counts with a new tests syntax where context is `image[/scenario]`. Closes cockpit-project#12368
|
Thanks @martinpitt for the review, fixed. Also we could drop the kubernetes all together from master, right? But maybe as a separate commit so it is easier to pick to stable branches? |
|
I tested this with |
External projects use this script to run tests. Let's do the same in Cockpit so `tests/invoke` does not have to differentiate between cockpit and external projects. This counts with a new tests syntax where context is `image[/scenario]`. Closes cockpit-project#12368
External projects use this script to run tests. Let's do the same in Cockpit so `tests/invoke` does not have to differentiate between cockpit and external projects. This counts with a new tests syntax where context is `image[/scenario]`. Closes #12368
External projects use this script to run tests. Let's do the same in Cockpit so `tests/invoke` does not have to differentiate between cockpit and external projects. This counts with a new tests syntax where context is `image[/scenario]`. Closes #12368
External projects use this script to run tests. Let's do the same in
Cockpit so
tests/invokedoes not have to differentiate between cockpitand external projects.
This is not yet used. It is going to be enabled a bit later on, see #12367