lib/form-layout: Add support for widgets nested in splits

[garrett]

Fix alignment as mentioned in #11083 by applying special widget offseting & min-height to widgets also directly enclosed within ct-form-layout-split, which should behave now similarly to top-level children.

[garrett]

Ideally, the widget would be a direct child of the grid element. That's what splits are designed for. However, in looking at the code, it would be difficult to "fix" the HTML to work as intended, so I basically adjusted the CSS to account for cases like this, as it'll probably show up again in the future too (and isn't really "wrong").

[garrett]

Oh, this will probably clash with b384c4b, which hasn't been merged yet. That specific commit is similar and we can add this same logic to b384c4b#diff-065d8dbbc10bd4f648805392b2b935f6R137 (line 137)

[garrett]

Merged the two commits into one.

[andreasn]

The text is still one pixel off, but maybe that's a general problem with checkboxes? Look a lot better with this PR applied, in general, though.

[garrett]

The text is still one pixel off

Oh, hmm. I should investigate this. 😉

[garrett]

Fixed checkboxes and radios in various scenarios and added list-group-item fixes here now too. (Network page among others had odd stuff going on. I had some local fixes in another PR, but it really belongs here.)

[garrett]

I need to do further testing tomorrow and perhaps some little fixups, but wanted to come to a stopping point today with something that should (mostly?) work as expected.

[andreasn]

Looks good to me!

[garrett]

The changes here and in #11035 don't work well together. I'll have to investigate further to make everything work. It might be local to that PR, or perhaps I'm making wrong assumptions somewhere. 😒

[martinpitt]

Sorry, this fell through the cracks. This needs to be rebased.

[garrett]

That's OK: I'm not quite done with it either, if I remember correctly. I got pulled over to other PRs, interacting with other people on the other issues was more important than this fixup PR.

I'm also pretty certain I did some commit collisions with myself. 😉

[garrett]

Rebased, as to not let this get too stale; need to check (and fix) it everywhere still.

[garrett]

This merged version still has a few errors:

And things are probably off a pixel or two elsewhere (checkboxes, most likely). Still needs work.

[garrett]

I really need to find the time to finish this and de-conflict-ify it (again), then fix it up again. We still have a few bugs in Cockpit that are addressed in this PR.

[marusak]

Needs to rebase to master since #12367 changed tests names

[garrett]

I think I basically implemented this either during the PF4-style refresh or shortly before.