WIP: Show older logs #11120
Closed
WIP: Show older logs #11120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If N lines are requested from the logs panel, but all of them are same, only one line was shown (with count 10 on right side). After this commit 10 lines are shown. Closes cockpit-project#771
Since newer logs are prepended, keeping only last `max` logs does not make sense to me. Keeping only first `max` makes much more sense to me.
|
Needs to rebase to master since #12367 changed tests names |
|
Closing since I am not interested now into fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #771
I am opening this PR so someone can look at it and say if this approach makes sense.
Before:
After:
Known issues:
If the last line to be added happened in different day, we add two lines (line with day and the line itself). However then we cut to N lines and last line stays the day line. pics or it didn't happen -
When new lines are added (as they later happen) those appended are not removed. (Trying to figure this out, but thought that I will open this to see if I am walking in a right direction)