Logging support #37
Comments
marusak
referenced
this issue
in marusak/cockpit
Aug 28, 2019
ashley-cui
pushed a commit
to ashley-cui/cockpit
that referenced
this issue
Sep 13, 2024
Previously it was done by listening to libvirt-dbus. This commit also reimplements the way we are waiting for resource initialization. The previous implementation used to prefill the resources lists with empty objects (see initResource) so that the application would show 'Loading resources' indicator while empty objects still existed in the list. However, this got broken (3b100e0) resulting that the reducer function was never called, since the initResource methods were not properly dispatched. The decision to show the 'Loading resources' screen was mostly taken in the past to fix race conditions in tests, which would open dialogs, waiting for X resource to be present, but at the point the dialog was opened the resource initialization was not done yet. This commit, reapproaches the logic of how we block on the 'Loading resources' screen while waiting for the resource initialization to finish. Instead of prefilling the list with empty objects, which causes unnecessary state updates, we just rely on the promises to return. Fixes cockpit-project#37 Relevant to https://bugzilla.redhat.com/show_bug.cgi?id=1974223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This includes the ability to view device- and service- specific log entries, time lines, and support for searching and filtering.
The text was updated successfully, but these errors were encountered: