test: Factorize registry setup in testDownloadImage() #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
requested changes
Jan 7, 2025
test/check-application
Outdated
| self.execute(True, f"podman run -d -p 6000:5000 --name registry_alt --stop-timeout 0 {IMG_REGISTRY}") | ||
| # Add local insecure registry into registries conf | ||
| self.machine.write("/etc/containers/registries.conf", REGISTRIES_CONF) | ||
| self.setupRegistry() | ||
| self.execute(True, "systemctl stop podman.service") |
There was a problem hiding this comment.
This is already included in setupRegistry and doesn't need to be repeated here.
There was a problem hiding this comment.
Thanks for spotting! I meant to do that, but just forgot.
Use our setupRegistry() helper.
martinpitt
force-pushed
the
factor-registry
branch
from
ecf6faa to
d984f34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use our setupRegistry() helper.