support TFS git URLs #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolynx
requested review from
jayvdb and
retr0h
and removed request for
jayvdb
neolynx
force-pushed
the
feature/tfs-urls
branch
from
26aaee6
to
ee47864
Compare
improving the regex to parse more exotic URLs. Signed-off-by: André Roth <[email protected]>
neolynx
force-pushed
the
feature/tfs-urls
branch
from
ee47864
to
c19812b
Compare
sobh
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
This patch solves a problem I have with repositories owned by user with an all digits username on GitHub (I know 🤦♂️).
E.g.
Thus, the actual username gets wrongfully recognized as the port number. Leaving the owner empty.
Please 🙏 merge.
|
hi @HaloGithub I was the original author of this project, however, it has been transitioned to the Cola team. While I approve the PR, I probably shouldn't merge it, as I'm not responsible for releasing it. Might be best to reach out to the Cola project owners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improving the regex to parse more exotic URLs.
Signed-off-by: André Roth [email protected]