Recognize urls of the form git+https://github.com/tj/commander.js.git #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 31, 2019 15:31
These patterns are returned by npm registry, eg, http://registry.npmjs.com/commander where the protocols are bundled together. It would be nice if giturlparse could add this patterns too.
Recognize urls of the form git+https://github.com/tj/commander.js.git
Make the pattern for + upto one times instead of unlimited
|
Git url parses git urls. Adding npm seems to changes the intended scope. |
? this is for git urls: git+https://github.com/tj/commander.js.git |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patterns are returned by npm registry, eg, http://registry.npmjs.com/commander where the protocols are bundled together. It would be nice if giturlparse could add this patterns too.