Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2 incorrect submodules not listed in .gitmodules #2185

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

collivier
Copy link
Collaborator

Description

git ls-files --stage | grep 160000
160000 21041a38c5d6f66e92fb12a337ec07e675f1721b 0	sample-cnfs/sample-oran-noric/oran_ric
160000 21041a38c5d6f66e92fb12a337ec07e675f1721b 0	sample-cnfs/sample-oran-ric/oran_ric

It would clean a big part of the 89 errors and 225 warnings in our github actions.

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

git ls-files --stage | grep 160000
160000 21041a38c5d6f66e92fb12a337ec07e675f1721b 0	sample-cnfs/sample-oran-noric/oran_ric
160000 21041a38c5d6f66e92fb12a337ec07e675f1721b 0	sample-cnfs/sample-oran-ric/oran_ric

It would clean a big part of the 89 errors and 225 warnings in our github actions.

Signed-off-by: Cédric Ollivier <[email protected]>
@collivier collivier self-assigned this Dec 2, 2024
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@collivier collivier merged commit f8db490 into cnti-testcatalog:main Dec 3, 2024
83 checks passed
@collivier collivier deleted the fix_submodules branch December 3, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants