Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Kind logs to ease debugging #2174

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Export Kind logs to ease debugging #2174

merged 1 commit into from
Nov 13, 2024

Conversation

collivier
Copy link
Collaborator

@collivier collivier commented Nov 6, 2024 •
edited
Loading

It also deletes cluster after Oran testing

Description

No logs after failures in gates

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

martin-mat
martin-mat approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Smitholi67
Smitholi67 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@collivier
Export Kind logs to ease debugging
3cd1ff7 
It also deletes cluster after Oran testing

Signed-off-by: Cédric Ollivier <[email protected]>
kosstennbl
kosstennbl approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@kosstennbl kosstennbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-mat martin-mat merged commit 531e9a1 into cnti-testcatalog:main Nov 13, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosstennbl kosstennbl kosstennbl approved these changes

@Smitholi67 Smitholi67 Smitholi67 approved these changes

@martin-mat martin-mat martin-mat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@collivier @martin-mat @Smitholi67 @kosstennbl