Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: CNF installation (1) introduce new config format and parser #2129

Merged

Conversation

kosstennbl
Copy link
Collaborator

@kosstennbl kosstennbl commented Aug 8, 2024

Description

For supporting multiple deployments in one cnf and improving overall config usability and structure - new config format has to be introduced.
Some existing parameters usage need to be changed for easier adaptation.
This change does not replace the old config format.

Issues:

Refs: #2121

svteb added a commit to svteb/testsuite that referenced this pull request Aug 12, 2024
Refs: cnti-testcatalog#2130
- The transformer transforms the old config according to the
structure proposed in cnti-testcatalog#2129.

Signed-off-by: svteb <[email protected]>
svteb added a commit to svteb/testsuite that referenced this pull request Aug 12, 2024
Refs: cnti-testcatalog#2130
- The transformer transforms the old config according to the
structure proposed in cnti-testcatalog#2129.

Signed-off-by: svteb <[email protected]>
@kosstennbl kosstennbl force-pushed the new-config-format-parser branch 4 times, most recently from a6db1a0 to 3532bc1 Compare August 13, 2024 14:48
@kosstennbl kosstennbl marked this pull request as ready for review August 13, 2024 14:48
@kosstennbl kosstennbl force-pushed the new-config-format-parser branch 4 times, most recently from afabd19 to 3a01c4a Compare August 15, 2024 14:06
src/tasks/utils/cnf_installation/config.cr Outdated Show resolved Hide resolved
src/tasks/utils/cnf_installation/config.cr Outdated Show resolved Hide resolved
@kosstennbl kosstennbl force-pushed the new-config-format-parser branch 4 times, most recently from 1d0b3c9 to 7423726 Compare August 21, 2024 08:01
@kosstennbl kosstennbl force-pushed the new-config-format-parser branch 3 times, most recently from 8873911 to 1f28854 Compare August 29, 2024 08:58
@kosstennbl kosstennbl force-pushed the new-config-format-parser branch 2 times, most recently from 930872c to 02c6646 Compare September 2, 2024 08:16
svteb added a commit to svteb/testsuite that referenced this pull request Sep 2, 2024
Refs: cnti-testcatalog#2130
- Generic transformer for cnf yaml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in cnti-testcatalog#2129.

Signed-off-by: svteb <[email protected]>
svteb added a commit to svteb/testsuite that referenced this pull request Sep 5, 2024
Refs: cnti-testcatalog#2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in cnti-testcatalog#2129.

Signed-off-by: svteb <[email protected]>
For supporting multiple deployments in one cnf and
improving overall config usability and structure - new
config format has to be introduced.
Some existing parameters usage need to be changed
for easier adaptation.
This change does not replace the old config format.

Refs: cnti-testcatalog#2121
Signed-off-by: Konstantin Yarovoy <[email protected]>
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@svteb svteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

svteb added a commit to svteb/testsuite that referenced this pull request Sep 9, 2024
Refs: cnti-testcatalog#2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in cnti-testcatalog#2129.

Signed-off-by: svteb <[email protected]>
Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

svteb added a commit to svteb/testsuite that referenced this pull request Sep 13, 2024
Refs: cnti-testcatalog#2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in cnti-testcatalog#2129.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this pull request Sep 13, 2024
Refs: #2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in #2129.

Signed-off-by: svteb <[email protected]>
@martin-mat martin-mat merged commit ae06b22 into cnti-testcatalog:main Sep 15, 2024
87 checks passed
kosstennbl pushed a commit that referenced this pull request Sep 16, 2024
Refs: #2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in #2129.

Signed-off-by: svteb <[email protected]>
kosstennbl pushed a commit that referenced this pull request Sep 16, 2024
Refs: #2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in #2129.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this pull request Sep 19, 2024
Refs: #2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in #2129.

Signed-off-by: svteb <[email protected]>
kosstennbl pushed a commit that referenced this pull request Sep 19, 2024
Refs: #2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in #2129.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this pull request Sep 23, 2024
Refs: #2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in #2129.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this pull request Sep 25, 2024
Refs: #2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in #2129.

Signed-off-by: svteb <[email protected]>
martin-mat pushed a commit that referenced this pull request Sep 26, 2024
Refs: #2130
- Generic transformer for cnf-testsuite.yml configs to newer versions.
- Extendable through addition of new transformation rules.
- The current functionality transforms to configv2, the structure of which
was proposed in #2129.

Signed-off-by: svteb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants