Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate test "volume_hostpath_not_found" #2028

Merged
merged 1 commit into from
Jun 26, 2024
Merged

remove duplicate test "volume_hostpath_not_found" #2028

merged 1 commit into from
Jun 26, 2024

Conversation

martin-mat
Copy link
Collaborator

@martin-mat martin-mat commented May 15, 2024 •
edited
Loading

Description

"volume_hostpath_not_found" is duplicate of hostpath_mounts, thus removing.

Issues:

Refs: #2027
Refs: lfn-cnti/certification#132

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@martin-mat martin-mat force-pushed the remove_volume_hostpath_duplicate branch from 83f2362 to 7d474d4 Compare May 15, 2024 12:43
@taylor taylor mentioned this pull request May 15, 2024
Closed
kosstennbl
kosstennbl requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@kosstennbl kosstennbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation needs to be adjusted after merge of #1955
Otherwise ok, all mentions of the test seem to be deleted

@martin-mat martin-mat force-pushed the remove_volume_hostpath_duplicate branch from 7d474d4 to 67f81d0 Compare June 25, 2024 20:48
kosstennbl
kosstennbl approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@kosstennbl kosstennbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

horecoli
horecoli approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@horecoli horecoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Smitholi67
Smitholi67 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martin-mat martin-mat merged commit 9497fd6 into cnti-testcatalog:main Jun 26, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosstennbl kosstennbl kosstennbl approved these changes

@Smitholi67 Smitholi67 Smitholi67 approved these changes

@denverwilliams denverwilliams Awaiting requested review from denverwilliams denverwilliams is a code owner

@wvwatson wvwatson Awaiting requested review from wvwatson

@agentpoyo agentpoyo Awaiting requested review from agentpoyo agentpoyo is a code owner

@taylor taylor Awaiting requested review from taylor

@rich-l rich-l Awaiting requested review from rich-l

@horecoli horecoli Awaiting requested review from horecoli

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@svteb svteb Awaiting requested review from svteb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin-mat @Smitholi67 @kosstennbl @horecoli