-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-drain: Fix link to experiment #2024
Conversation
In 69dedb3, Litmus version was updated And all links for experiments were changed accordingly except for the node_drain. This commit fixes that. ref: cnti-testcatalog#2022 Signed-off-by: Konstantin Yarovoy <[email protected]>
|
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec test before this change should fail and the spec should pass after this fix.
If not the spec should be updated to produce these results before this is merged to ensure we have coverage.
there is a good spec test for node_drain The real reason why the issue was not detected earlier during github actions is that they use one-node kind setup for testing. node_drain test needs multi-node setup and the spec tests "passes" because the test is "skipped". ⏭️ 🏆SKIPPED: [node_drain] node_drain chaos test requires the cluster to have atleast two schedulable nodes 🗡️💀♻ The spec tests is happy with such skipping:
So I propose to adapt github actions so they run on kind with 2 schedulable nodes |
@martin-mat I have verified that the fix for node drain works as a single test and in the cert command. However, I will say the cert command does not ever finish, which appears to be a seperate issue from node drain. It may pertain to either sig_term_handled, zombie_handled, or specialized_init_system. The logging doesn't appear to indicate where we are stuck. But for this ticket I think the fix for node_drain should go in. `---
|
@daniel-wilmes please open a new issue for
You can try disabling those with ~testname (eg. ~sig_term_handled) and isolate which test needs to be investigated. Add that info to the new ticket you create. cc: @Smitholi67 |
@martin-mat good catch on the kind in github actions. #2024 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and specs pass
In 69dedb3, Litmus version was updated And all links for experiments were changed accordingly except for the node_drain. This commit fixes that.
ref: #2022