Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Add possibility to log into file #2008

Merged
merged 1 commit into from
May 14, 2024

Conversation

kosstennbl
Copy link
Collaborator

Description

Add processing of environment variables LOGPATH and LOG_PATH If either one exists - logger will log into the file on that path instead of STDOUT.

Issues:

Refs: #2000

How has this been tested:

Manual testing of the functionality.
Running new spec.

Types of changes:

New non-breaking feature

Checklist:

Documentation
No documentation update is needed.

USAGE.md Outdated Show resolved Hide resolved
Add processing of environment variables LOGPATH and LOG_PATH
If either one exists - logger will log into the file on that
path instead of STDOUT.

refs: cnti-testcatalog#2000

Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl force-pushed the log-path-addition branch from 76a7632 to 622d7d7 Compare May 2, 2024 08:38
Copy link
Collaborator

@HashNuke HashNuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will try this out on the pair machine and push to build on github actions.

@martin-mat martin-mat self-requested a review May 14, 2024 13:24
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taylor taylor merged commit 595065a into cnti-testcatalog:main May 14, 2024
15 of 94 checks passed
@kosstennbl kosstennbl deleted the log-path-addition branch May 27, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants