Prevent microservice tests from passing on errors #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-mat
requested review from
denverwilliams,
wvwatson and
agentpoyo
as code owners
martin-mat
force-pushed
the
microservice_false_positive
branch
from
b0e5575
to
931532d
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Updated description:
|
taylor
requested changes
Apr 15, 2024
There was a problem hiding this comment.
@martin-mat I think this should be SKIPPED vs NA for the state.
Skipped: lack of capability, error in test, error in cnf
cc: @denverwilliams @wavell @HashNuke
Refs: cnti-testcatalog#1959 This updates the behaviour so the test will not pass when there is an environment or external error causing the test to not be able to do a complete validation as intended. (eg. the containers could not be inspected because of an external unrelated issue). The error is reported and the test will not pass. Signed-off-by: Martin Matyas <[email protected]>
martin-mat
force-pushed
the
microservice_false_positive
branch
from
931532d
to
81f405d
Compare
wvwatson
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the behaviour so the test will not pass when there is an environment or external error causing the test to not be able to do a complete validation as intended. (eg. the containers could not be inspected because of an external unrelated issue).
The error is reported and the test will not pass.
Issues:
Refs: #1959
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue