-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add test name before and after the test in console output #1962
Enhancement: Add test name before and after the test in console output #1962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kosstennbl Have you tried running the automated tests to check if they pass?
Quite a lot of the automated tests depend on assertions which use the pass/fail message. They would have to be updated appropriately.
Screenshot below is an example:
True, i forgot about that. |
Waits for merge of #1954 |
Please create WIP or DRAFT PRs as DRAFT's when creating, this will prevent any accidental merges as "Draft" status will grey out the "merge" button until they're actually ready for review and merging. |
532b929
to
5a1512d
Compare
I've changed the status of this PR to draft to reflect the title. |
5a1512d
to
f450b81
Compare
Ready to test, not a draft anymore. Btw, i can't change status from draft to open (probably insufficient permissions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 lgtm
Note/Warning: the new regex in the specs using .* has had issues in the past with multiline PASS/FAIL output and incorrect results.
cc: @wavell @denverwilliams
@kosstennbl I held back on this PR because the main branch builds were broken. I've made some fixes to the kubescape issues in the |
@HashNuke |
@kosstennbl Quick update - #2004 has been merged into main. This PR is now showing 2 conflicts. |
f450b81
to
a0daaa7
Compare
@HashNuke Rebase done, please run tests. |
@kosstennbl There are two failing tags in the build - https://github.com/cnti-testcatalog/testsuite/actions/runs/8860425833/job/24331957328
|
Ref: cnti-testcatalog#1958 Add information of which test is starting to the console output Add test name to test result console output Signed-off-by: Konstantin Yarovoy <[email protected]>
a0daaa7
to
4b43358
Compare
@HashNuke Fixed task_runner (checked localy - it passed), deleted exposed_dashboard. |
Build passing - https://github.com/cnti-testcatalog/testsuite/actions/runs/8861261394 Will wait for the main branch build to pass before merging this PR. |
Add information of which test is starting to the console output
Add test name to test result console output
Issues:
Refs: #1958
No documentation update is needed.
Only outputs have been modified, functionality shouldn't be affected in any way.