Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Remove Ameba from shard dependencies #2157

Closed
kosstennbl opened this issue Sep 26, 2024 · 0 comments
Closed

[MAINTENANCE] Remove Ameba from shard dependencies #2157

kosstennbl opened this issue Sep 26, 2024 · 0 comments
Labels
maintenance

Comments

@kosstennbl
Copy link
Collaborator

Ameba is a crystal-lang static linting tool, which can be ran in different ways. https://github.com/crystal-ameba/ameba

Currently we experience issues with upgrading crystal version due to incompatible versions of ameba and crystal.
And even through Ameba is mentioned in dependencies of testsuite, it isn't being used in any way for CI or otherwise.

Proposal is to remove Ameba from project dependencies, and then, in future issues, update crystal version and later, add Ameba to CI via building it from source.

No other projects under testsuite use Ameba, it should be safe to only remove it from shard.yml and shard.lock here.
This was referenced Sep 26, 2024
Open
Open
kosstennbl pushed a commit to kosstennbl/cnf-testsuite that referenced this issue Sep 27, 2024
ameba: Remove ameba from shard dependencies
8c08d15 
Ameba is a linting tool, which isn't being used in our CI
pipelines, and causes complications with crystal version update.
Ameba dependency should be removed from cnf-testcatalog shards
and usage guidelines should point to more independent usage via
installing the linter from source.

Refs: cnti-testcatalog#2157
Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl mentioned this issue Sep 27, 2024
Merged
martin-mat added a commit that referenced this issue Oct 2, 2024
@martin-mat
ameba: Remove ameba from shard dependencies (#2160)
391373a 
* ameba: Remove ameba from shard dependencies

Ameba is a linting tool, which isn't being used in our CI
pipelines, and causes complications with crystal version update.
Ameba dependency should be removed from cnf-testcatalog shards
and usage guidelines should point to more independent usage via
installing the linter from source.

Refs: #2157
Signed-off-by: Konstantin Yarovoy <[email protected]>

* Update USAGE.md

Signed-off-by: Martin Matyas <[email protected]>

---------

Signed-off-by: Konstantin Yarovoy <[email protected]>
Signed-off-by: Martin Matyas <[email protected]>
Co-authored-by: Martin Matyas <[email protected]>
@kosstennbl kosstennbl mentioned this issue Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martin-mat @kosstennbl