Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Remove and exchange duplicate test for privileged containers #2115

Closed
horecoli opened this issue Jul 30, 2024 · 0 comments
Closed

[MAINTENANCE] Remove and exchange duplicate test for privileged containers #2115

horecoli opened this issue Jul 30, 2024 · 0 comments
Labels
maintenance

Comments

@horecoli
Copy link
Contributor

In the current version of the testsuite, there are 2 tests for privileged containers. They are:

  • The "in-house" implementation (privileged) which allows for the exclusion of certain containers from the test.
  • The Kubescape solution (privileged_containers) which lacks this functionality to exclude containers from the test.

Since privileged_containers is an essential test, it would be better to replace it with the privileged test, which fulfills the requirements including container exclusion. The best solution would be to swap the names of these two tests and remove the Kubescape implementation, at least until container exclusion functionality is implemented in the Kubescape repository.
horecoli added a commit to horecoli/cnf-testsuite that referenced this issue Jul 31, 2024
@horecoli
Removal and exchange duplicate test for privileged containers
680c9bb 
This change removes the Kubescape implementation of test
for privileged containers. The reason behind this decision
is the absence of functionality to exclude containers
from the test. Instead, it has been replaced with an in-house
implementation of this test, which has been renamed
from "privileged" to "privileged_containers".

Implements: cnti-testcatalog#2115
Signed-off-by: horecoli <[email protected]>
@horecoli horecoli mentioned this issue Jul 31, 2024
Merged
20 tasks
horecoli added a commit to horecoli/cnf-testsuite that referenced this issue Aug 1, 2024
@horecoli
Removal and exchange duplicate test for privileged containers
9a47a29 
This change removes the Kubescape implementation of test
for privileged containers. The reason behind this decision
is the absence of functionality to exclude containers
from the test. Instead, it has been replaced with an in-house
implementation of this test, which has been renamed
from "privileged" to "privileged_containers".

Implements: cnti-testcatalog#2115
Signed-off-by: horecoli <[email protected]>
horecoli added a commit to horecoli/cnf-testsuite that referenced this issue Aug 1, 2024
@horecoli
Removal and exchange duplicate test for privileged containers
8c7f5c2 
This change removes the Kubescape implementation of test
for privileged containers. The reason behind this decision
is the absence of functionality to exclude containers
from the test. Instead, it has been replaced with an in-house
implementation of this test, which has been renamed
from "privileged" to "privileged_containers".

Implements: cnti-testcatalog#2115
Signed-off-by: horecoli <[email protected]>
horecoli added a commit to horecoli/cnf-testsuite that referenced this issue Aug 5, 2024
@horecoli
Removal and exchange duplicate test for privileged containers
1fd4080 
This change removes the Kubescape implementation of test
for privileged containers. The reason behind this decision
is the absence of functionality to exclude containers
from the test. Instead, it has been replaced with an in-house
implementation of this test, which has been renamed
from "privileged" to "privileged_containers".

Implements: cnti-testcatalog#2115
Signed-off-by: horecoli <[email protected]>
horecoli added a commit to horecoli/cnf-testsuite that referenced this issue Aug 5, 2024
@horecoli
Removal and exchange duplicate test for privileged containers
860c576 
This change removes the Kubescape implementation of test
for privileged containers. The reason behind this decision
is the absence of functionality to exclude containers
from the test. Instead, it has been replaced with an in-house
implementation of this test, which has been renamed
from "privileged" to "privileged_containers".

Implements: cnti-testcatalog#2115
Signed-off-by: horecoli <[email protected]>
martin-mat pushed a commit that referenced this issue Aug 7, 2024
@horecoli
Removal and exchange duplicate test for privileged containers (#2119)
0a33918 
This change removes the Kubescape implementation of test
for privileged containers. The reason behind this decision
is the absence of functionality to exclude containers
from the test. Instead, it has been replaced with an in-house
implementation of this test, which has been renamed
from "privileged" to "privileged_containers".

Implements: #2115

Signed-off-by: horecoli <[email protected]>
@horecoli horecoli closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@horecoli