Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] One of the shared DB spec tests doesn't cleanup pvc #2017

Closed
horecoli opened this issue May 9, 2024 · 0 comments
Closed

[BUG] One of the shared DB spec tests doesn't cleanup pvc #2017

horecoli opened this issue May 9, 2024 · 0 comments
Assignees
@horecoli
Labels
bug Something isn't working v1.3.0 Issue included in v1.3.0 release

Comments

@horecoli
Copy link
Contributor

horecoli commented May 9, 2024

Describe the bug
One of the shared DB spec test in microservice_spec.cr is not removing pvc during cleanup.
Before execution of spec test:
image

After execution of spec test:
image

To Reproduce
Run spec test:
crystal spec spec/workload/microservice_spec.cr:59
and check pvcs by:
kubectl get pvc -A

Expected behavior
Cleanup should remove everything from cnf.
@horecoli horecoli added the bug Something isn't working label May 9, 2024
horecoli added a commit to horecoli/cnf-testsuite that referenced this issue May 9, 2024
@horecoli
spec: Add removal of pvc in the end of spec test
f005d0c 
In one of shared DB spec tests was missing removal
of pvc which was created during cnf setup.
This change adds this removal.

Closes-Bug: cnti-testcatalog#2017
Signed-off-by: horecoli <[email protected]>
@horecoli horecoli mentioned this issue May 9, 2024
Merged
20 tasks
@lixuna lixuna moved this to Peer Review in CNTI Test Catalog May 10, 2024
@lixuna lixuna added the v1.3.0 Issue included in v1.3.0 release label May 10, 2024
taylor pushed a commit that referenced this issue May 14, 2024
@horecoli
spec: Add removal of pvc in the end of spec test (#2018)
1464801 
In one of shared DB spec tests was missing removal
of pvc which was created during cnf setup.
This change adds this removal.

Closes-Bug: #2017

Signed-off-by: horecoli <[email protected]>
@github-project-automation github-project-automation bot moved this from Peer Review to Done in CNTI Test Catalog May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@horecoli horecoli

Labels
bug Something isn't working v1.3.0 Issue included in v1.3.0 release
Projects
CNTI Test Catalog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lixuna @horecoli