Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Outdated helm repo path in fluentd bitnami install #2016

Closed
svteb opened this issue May 7, 2024 · 0 comments
Closed

[BUG] Outdated helm repo path in fluentd bitnami install #2016

svteb opened this issue May 7, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@svteb
Copy link
Collaborator

svteb commented May 7, 2024

Describe the bug

From /testsuite/src/tasks/utils/fluentd_bitnami.cr:

module FluentDBitnami
  def self.install
    #todo use embedded file to install fluentd values over fluent helm
    #chart
    Log.info {"Installing FluentD Bitnami daemonset "}
    # File.write("fluentd-values.yml", FLUENTD_VALUES)
    # Helm.helm_repo_add("fluent","https://fluent.github.io/helm-charts")
    Helm.helm_repo_add("bitnami","oci://registry-1.docker.io/bitnamicharts")          <---         offender
    #
    # # Install fluentd in the cnf-testsuite namespace
    # Helm.install("--values ./fluentd-values.yml -n #{TESTSUITE_NAMESPACE} fluentd fluent/fluentd")
    # Helm.helm_repo_add("fluent", "https://fluent.github.io/helm-charts")
    Helm.install("--set aggregator.enabled=false -n #{TESTSUITE_NAMESPACE} fluentd bitnami/fluentd")
    KubectlClient::Get.resource_wait_for_install("Daemonset", "fluentd", namespace: TESTSUITE_NAMESPACE)
  end

Unless some authorization is required the repo oci://registry-1.docker.io/bitnamicharts fails with:

Error: looks like "oci://registry-1.docker.io/bitnamicharts" is not a valid chart repository or cannot be reached: object required

To Reproduce

helm repo add bitnami oci://registry-1.docker.io/bitnamicharts

Expected behavior
Some live bitnami helm repo should be used, i.e https://charts.bitnami.com/bitnami.

@svteb svteb added the bug Something isn't working label May 7, 2024
svteb added a commit to svteb/testsuite that referenced this issue May 16, 2024
Ref: cnti-testcatalog#2025 cnti-testcatalog#2016
- The issue explained in cnti-testcatalog#2025 where fluent was tailing itself
instead of the CNF has been resolved.
- The dead helm repo mentioned in cnti-testcatalog#2016 has been replace by link to bitnami repo,
there was a similar occurence in the spec test.
- The family of fluentd functions and files have been refactored into configurable
files (allows for future additions/checking of elastic, aws fluent, etc.).
- The routed_logs test was also modified to conform to the new functions (also shortened).
- Other files have been edited for completion/conformance with naming conventions.
Signed-off-by: svteb <[email protected]>
martin-mat pushed a commit that referenced this issue Jun 9, 2024
Ref: #2025 #2016
- The issue explained in #2025 where fluent was tailing itself
instead of the CNF has been resolved.
- The dead helm repo mentioned in #2016 has been replace by link to bitnami repo,
there was a similar occurence in the spec test.
- The family of fluentd functions and files have been refactored into configurable
files (allows for future additions/checking of elastic, aws fluent, etc.).
- The routed_logs test was also modified to conform to the new functions (also shortened).
- Other files have been edited for completion/conformance with naming conventions.
Signed-off-by: svteb <[email protected]>
martin-mat pushed a commit that referenced this issue Jun 10, 2024
)

* Fix: Routed logs test now correctly checks if CNF is being tailed
Ref: #2025 #2016
- The issue explained in #2025 where fluent was tailing itself
instead of the CNF has been resolved.
- The dead helm repo mentioned in #2016 has been replace by link to bitnami repo,
there was a similar occurence in the spec test.
- The family of fluentd functions and files have been refactored into configurable
files (allows for future additions/checking of elastic, aws fluent, etc.).
- The routed_logs test was also modified to conform to the new functions (also shortened).
- Other files have been edited for completion/conformance with naming conventions.
Signed-off-by: svteb <[email protected]>

* Fix: Corrected a require command in observability_spec.cr
Refs: #2025

Signed-off-by: svteb <[email protected]>

* Refactor: better abstraction of fluent flavors
Refs: #2025
- Reworked the config dictionary into classes that inherit
from a base abstract class.
- Renamed FluentManagement module to FluentManager
- Interfaces changed to adhere to the new abstraction

Signed-off-by: svteb <[email protected]>

---------

Signed-off-by: svteb <[email protected]>
@svteb svteb closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant