Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pod_delete test outputs API text during cert run #1974

Closed
agentpoyo opened this issue Apr 15, 2024 · 3 comments
Closed

[BUG] pod_delete test outputs API text during cert run #1974

agentpoyo opened this issue Apr 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working cnti-certification Enhancements to support CNTI Certification program one summit 2024 Issue prioritized for ONE Summit (May 1) v1.0.0 Issue included in v1.0.0 release

Comments

@agentpoyo
Copy link
Collaborator

Describe the bug
There seems to be API output when running the cert option that should be suppressed information as it breaks the PASS/FAIL/SKIP output when running the testsuite

To Reproduce
Run cert against your CNF, in this example it was the sample-coredns-cnf/ configuration sample.

Expected behavior
There should be no template or config API output when running the certification as it breaks the formatting of the output for tests.

Screenshots

Reliability, Resilience, and Availability Tests
✔️  ✨PASSED: pod_network_latency chaos test passed 🗡️💀♻
✔️  ✨PASSED: pod_network_corruption chaos test passed 🗡️💀♻
✔️  PASSED: disk_fill chaos test passed 🗡️💀♻
Running for: {"app.kubernetes.io/instance" => "coredns", "app.kubernetes.io/name" => "coredns", "k8s-app" => "coredns"}
Spec Hash: 
template: apiVersion: litmuschaos.io/v1alpha1
kind: ChaosEngine
metadata:
  name: coredns-coredns-26
  namespace: cnfspace
spec:
  engineState: 'active'
  appinfo:
    appns: 'cnfspace'
    applabel: 'app.kubernetes.io/instance=coredns'
    appkind: 'deployment'
  chaosServiceAccount: pod-delete-sa
  jobCleanUpPolicy: 'delete'
  experiments:
    - name: pod-delete
      spec:
        components:
          env:
            # specify the fill percentage according to the disk pressure required
            - name: TOTAL_CHAOS_DURATION
              value: '30'

            - name: CHAOS_INTERVAL
              value: '10'

            - name: TARGET_PODS
              value: ''
            - name: FORCE
              value: 'false'
✔️  PASSED: pod_delete chaos test passed 🗡️💀♻
Screenshot 2024-04-15 at 12 50 18 PM
@agentpoyo agentpoyo added the bug Something isn't working label Apr 15, 2024
@agentpoyo agentpoyo added one summit 2024 Issue prioritized for ONE Summit (May 1) v1.0.0 Issue included in v1.0.0 release labels Apr 15, 2024
@agentpoyo agentpoyo moved this to Todo in CNTI Test Catalog Apr 15, 2024
taylor added a commit that referenced this issue Apr 15, 2024
Removing dev logging output using puts or replacing with Log.info where needed.

ref: #1974
@agentpoyo agentpoyo moved this from Todo to Peer Review in CNTI Test Catalog Apr 15, 2024
@agentpoyo
Copy link
Collaborator Author

Checking out branch issue-1974 shows the API text no longer appears when pod_delete is run:

pair@cnfdev4:~/workspace/drew/testsuite$ ./cnf-testsuite pod_delete
✔️  PASSED: pod_delete chaos test passed 🗡️💀♻

Once passing github actions, this will be merged into main

@agentpoyo agentpoyo added the cnti-certification Enhancements to support CNTI Certification program label Apr 16, 2024
wvwatson pushed a commit that referenced this issue Apr 19, 2024
Removing dev logging output using puts or replacing with Log.info where needed.

ref: #1974
@lixuna
Copy link
Collaborator

lixuna commented Apr 23, 2024

@agentpoyo is this passing github actions? Can this be closed?

@agentpoyo
Copy link
Collaborator Author

Yes, this is fixed. Closing. Thanks.

@github-project-automation github-project-automation bot moved this from Peer Review to Done in CNTI Test Catalog Apr 23, 2024
haskojur pushed a commit to haskojur/testsuite that referenced this issue Apr 24, 2024
Removing dev logging output using puts or replacing with Log.info where needed.

ref: cnti-testcatalog#1974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cnti-certification Enhancements to support CNTI Certification program one summit 2024 Issue prioritized for ONE Summit (May 1) v1.0.0 Issue included in v1.0.0 release
Projects
Status: Done
Development

No branches or pull requests

4 participants