Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove Log.info wrappers when running shell commands in spec tests #1495

Closed
HashNuke opened this issue Jun 8, 2022 · 2 comments
Closed

[BUG] Remove Log.info wrappers when running shell commands in spec tests #1495

HashNuke opened this issue Jun 8, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@HashNuke
Copy link
Collaborator

HashNuke commented Jun 8, 2022 •
edited
Loading

Describe the bug

Running shell commands in Log.info { } would result in the command being skipped when the log level is higher or not set.
So when the log level is higher, then the spec test would fail.

CleanShot 2022-06-08 at 18 38 34@2x
@HashNuke HashNuke added the bug Something isn't working label Jun 8, 2022
@HashNuke HashNuke self-assigned this Jun 8, 2022
@horecoli horecoli mentioned this issue Feb 16, 2024
Closed
@macaktom
Copy link
Contributor

I can look into this task.

@macaktom macaktom mentioned this issue Mar 6, 2024
Closed
9 tasks
@lixuna lixuna moved this to In Progress in CNTI Test Catalog Mar 18, 2024
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 8, 2024
@kosstennbl
spec: remove backticks and use new logging
ea03a20 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues.
This commit breaks commented out code, it should be removed later
or rewritten if uncommented.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 8, 2024
@kosstennbl
spec: remove backticks and use new logging
469f6c9 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues.
This commit breaks commented out code, it should be removed later
or rewritten if uncommented.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 8, 2024
@kosstennbl
spec: remove backticks and use new logging
567b7fc 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues.
This commit breaks commented out code, it should be removed later
or rewritten if uncommented.

Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl mentioned this issue Apr 8, 2024
Merged
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 9, 2024
@kosstennbl
spec: remove backticks and use new logging
287d798 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues.
This commit breaks commented out code, it should be removed later
or rewritten if uncommented.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 9, 2024
@kosstennbl
spec: remove backticks and use new logging
0be37e5 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues.
This commit breaks commented out code, it should be removed later
or rewritten if uncommented.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 10, 2024
@kosstennbl
spec: refactor spec tests
bf7d6dd 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 10, 2024
@kosstennbl
spec: refactor spec tests
b2f088f 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 11, 2024
@kosstennbl
spec: refactor spec tests
cdcbaf3 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 12, 2024
@kosstennbl
spec: remove backticks and use new logging
1ebb5ee 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 12, 2024
@kosstennbl
spec: remove backticks and use new logging
2152086 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 16, 2024
@kosstennbl
spec: remove backticks and use new logging
23f022d 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 16, 2024
@kosstennbl
spec: remove backticks and use new logging
7808f17 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 16, 2024
@kosstennbl
spec: remove backticks and use new logging
b9408a7 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 16, 2024
@kosstennbl
spec: remove backticks and use new logging
244b178 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 16, 2024
@kosstennbl
spec: remove backticks and use new logging
5961641 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 19, 2024
@kosstennbl
spec: remove backticks and use new logging
7c16f09 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 19, 2024
@kosstennbl
spec: remove backticks and use new logging
ba63fc4 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 22, 2024
@kosstennbl
spec: remove backticks and use new logging
af7b839 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 22, 2024
@kosstennbl
spec: remove backticks and use new logging
98d16cb 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 23, 2024
@kosstennbl
spec: remove backticks and use new logging
744a33a 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
@lixuna lixuna moved this from In Progress to Peer Review in CNTI Test Catalog Apr 23, 2024
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue Apr 29, 2024
@kosstennbl
spec: remove backticks and use new logging
aa0da32 
REF: cnti-testcatalog#1495
Replace all backtick command execution with ShellCmd module.
Use Log instead of LOGGING module.
Fix edgecase issues caused by logging refactor.
Remove commented-out code.

Signed-off-by: Konstantin Yarovoy <[email protected]>
@github-project-automation github-project-automation bot moved this to Needs Peer Review in CNF Test Suite Aug 30, 2024
@kosstennbl
Copy link
Collaborator

Was fixed as a part of #1954

@github-project-automation github-project-automation bot moved this from Needs Peer Review to Done in CNF Test Suite Sep 4, 2024
@github-project-automation github-project-automation bot moved this from Peer Review to Done in CNTI Test Catalog Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CNF Test Suite
Status: Done
CNTI Test Catalog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HashNuke @macaktom @kosstennbl