fix: dont add quotes on node global bin path on Windows #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #318 +/- ##
=========================================
- Coverage 92.86% 92.76% -0.1%
=========================================
Files 29 29
Lines 2060 2060
Branches 359 359
=========================================
- Hits 1913 1911 -2
- Misses 147 149 +2
Continue to review full report at Codecov.
|
fengmk2
force-pushed
the
use-cmd-shim-hotfix-for-3.x
branch
from
328d345 to
82a22c1
Compare
dead-horse
reviewed
Dec 10, 2019
| @@ -4,7 +4,7 @@ const chalk = require('chalk'); | |||
| const debug = require('debug')('npminstall:bin'); | |||
| const path = require('path'); | |||
| const fs = require('mz/fs'); | |||
| const cmdShim = require('cmd-shim'); | |||
| const cmdShim = require('cmd-shim-hotfix'); | |||
|
3.25.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick from #317