Add new KubectlClient.exec_bg
helper
#5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Refs: cncf/cnf-testsuite#1738
Description
These changes help with resolving compile issues mentioned in cncf/cnf-testsuite#1738
background
arg fromKubectlClient.exec
. This caused errors due to unexpected return value when used in the testsuite.KubectlClient.exec_bg
for executing in the background. This should help any ongoing work in other branches and behaves the same as the earlierexec
helper withbackground=true
.Additional changes to help smooth transition for cncf/cnf-testsuite#1726
cncf/cnf-testsuite
.kubectl_client
works with the cnf-testsuite when compiled.cncf/cnf-testsuite
bug/1738
More notes
For validation against the
main
branch of cnf-testsuite: Thisexec-background
branch ofkubectl_client
is now being used by thebug/1726
branch ofcncf/cnf-testsuite
and the build is green.How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue