Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new KubectlClient.exec_bg helper #5

Merged
merged 6 commits into from
Feb 14, 2023
Merged

Add new KubectlClient.exec_bg helper #5

merged 6 commits into from
Feb 14, 2023

Conversation

HashNuke
Copy link
Contributor

Issues:

Refs: cncf/cnf-testsuite#1738

Description

These changes help with resolving compile issues mentioned in cncf/cnf-testsuite#1738

  • Removes background arg from KubectlClient.exec. This caused errors due to unexpected return value when used in the testsuite.
  • Adds new helper KubectlClient.exec_bg for executing in the background. This should help any ongoing work in other branches and behaves the same as the earlier exec helper with background=true.

Additional changes to help smooth transition for cncf/cnf-testsuite#1726

More notes

For validation against the main branch of cnf-testsuite: This exec-background branch of kubectl_client is now being used by the bug/1726 branch of cncf/cnf-testsuite and the build is green.

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@agentpoyo agentpoyo self-requested a review February 14, 2023 14:48
Copy link
Collaborator

@agentpoyo agentpoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agentpoyo agentpoyo merged commit 0edf963 into main Feb 14, 2023
williscool added a commit to cnti-testcatalog/testsuite that referenced this pull request Mar 7, 2023
should not have been committed once the exec-background branch of

cnf-testsuite/kubectl_client#5

was merged

Signed-off-by: William Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants