[bug/1798] Read local helm path from CUSTOM_HELM_PATH env var #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akash Manohar <[email protected]>
Signed-off-by: Akash Manohar <[email protected]>
|
Fixed GitHub annotation warning too. 
|
Merged
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: cncf/cnf-testsuite#1798
Change summary
CUSTOM_HELM_PATHenv var for local helm pathshard.ymlversion to1.0.2Before this change:
Local helm path was being read from the shard's current directory. This is within the
libdir when the shard is installed.After this change:
Local helm path is read from
CUSTOM_HELM_PATHenv var if set and if the file is available.Reason for this change
The cnf-testsuite project installs Helm in a path relative to the testsuite binary. To be able to find the custom helm binary, the shard needs to be informed about the custom helm path.