Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the comment density metric in synthesis report part #236

Merged
merged 1 commit into from
May 10, 2021
Merged

Add the comment density metric in synthesis report part #236

merged 1 commit into from
May 10, 2021

Conversation

ErwanGauduchon
Copy link
Contributor

Proposed changes

Add the global comment density in the synthesis table of the report.

Types of changes

What types of changes does your code introduce to this software?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

Checklist

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • SonarCloud and Travis CI tests pass with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Sancretor Sancretor linked an issue May 7, 2021 that may be closed by this pull request
Add Comment Density in Docx Synthesis #233
Closed
Sancretor
Sancretor reviewed May 7, 2021
View reviewed changes
Copy link
Contributor

@Sancretor Sancretor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK, still need to look at the render in docx/md files.

@Sancretor Sancretor merged commit 3f95838 into dev May 10, 2021
@Sancretor Sancretor deleted the new-report-metric branch May 10, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sancretor Sancretor Sancretor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Comment Density in Docx Synthesis
2 participants
@ErwanGauduchon @Sancretor