Logger, Exception & minor fixes #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 4, 2017 18:16
- Every exceptions thrown by checkers are sending more informative messages - Code was improved as defined in cnescatlab#77 with a logger & part of PMD & checkstyle issues were solved About the logger, a new class UILogger was made. It runs org.eclipse.logger logger so all the logs are written directly to /*.log file of ./metadata of workspace and /configuration of eclipse folder. To precise the level of log a parameter must be indicated on the launch, as defined in this page : (https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fruntime-options.html ). So the following argument can be used to define level of the logger -Declipse.log.level=<level> where level can be INFO, WARNING, or ERROR. An important change was made on ConfigurationPagePreferences that was using CheckerTableViewer and MetricsTableViewer in a composite Container. These class are now extending Composite that contains a search SWT.label, a SWT.Text (for the search input) and a TableViewer with Checkers and parameters relatives to them. Old composite containing these class was replaced by the new CheckerComposite and MetricsComposite.
… differ. View displays informations of violations of the same file, rules, and same line only in the case the message differs, this happens frequently when message contains variables names. However, violations raised by the analysis on the same file on the same line with the same message willn't be displayed.
+ New columns (language & message) + String [--] was removed in Values column when a violation has no value and replaced by an empty string. + information on file are being displayed only when the checker has a value + separator which was [,] was edited to be a tab [\t] as some message contains commas.
begarco
pushed a commit
to begarco/i-CodeCNES
that referenced
this pull request
Jan 25, 2020
Logger, Exception & minor fixes
begarco
pushed a commit
that referenced
this pull request
Feb 2, 2020
Logger, Exception & minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
JFlexExceptionimprovementJFlexExceptionclass;ICodeLogger( Log does not appear into the log file #88 ).metadatafolder and in./configurationfolder of eclipse executable)WARNINGand can be configured in theicode.inifile with the jvm argumentDeclipse.log.level=<level>and set to ALL, OK, INFO, WARNING & ERROR.Exportclass into two services (ExportService&ImportService) ( Import/Export class names are really confusing #60 )mvn install -Dskiptestthenmvn verifyas unit test handled by tycho are run only after package phase of maven's lifecycle. ( Travis-CI do not run test on build #71 )ViolationsView. Violation of the same line but having different message (usually based on different variable of the same line) are now being displayed.languagewhich contains now the language identifier instead of the file extension. ( Language displayed in XML export is only the file extension #91 )