Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of the analyzer #16

Closed
WaldoFR opened this issue May 10, 2017 · 1 comment
Closed

Simplification of the analyzer #16

WaldoFR opened this issue May 10, 2017 · 1 comment
Assignees
Milestone

Comments

@WaldoFR
Copy link

WaldoFR commented May 10, 2017

Inventory

Currently i-Code Analyzer is designed to run an analysis with :

  • A list of IPath to run the analysis on;
  • A configuration based on the plugin preferences;
    It's is also using IPath in it's Violation & FileValue objects returned by the analysis.

Enhancement

We would like to improve it to be able to run an analysis on non-eclipse based thirds, and retrieving only one list of results instead of returning a List<Violation> and a List<FileValue>. This imply to have a common object for both metrics and violations analysis's result and should be realized with a fusion of the two analysis which are independant for now.

@WaldoFR WaldoFR self-assigned this May 10, 2017
@WaldoFR
Copy link
Author

WaldoFR commented May 10, 2017

A dedicated branch AnalyzerSimplification has been created to realize this enhancement.
Build Status

dupuisa added a commit that referenced this issue May 16, 2017
Fix #14 & Update #16 using File instead of IPath
dupuisa added a commit that referenced this issue Jun 12, 2017
@WaldoFR WaldoFR modified the milestone: Version 3.0 Jul 5, 2017
@WaldoFR WaldoFR closed this as completed Jul 5, 2017
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
Violation and FileValue had both a file attribute which type was IPath.
Changing it into File from java.io.File package imply a lot of little
modifications in files using theses objects.
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
Last modification of lex files didn't include the removal of unused
import in metrics.
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
Fix #14 & Update #16 using File instead of IPath
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
Changelog :
- Removal of the old Analyzer in the Analyzer plugin;
- Removal of the analysis handler in the UI plugin
- Add of an Analyzer plugin runnable from any third using
applyRules(List<File>,List<String>,List<String>) and
computeMetrics(List<File>,List<String>,List<String>) indicating files &
languages to run the analysis on. 
- Analyzer is now responsible to run the appropriate files on the good
analyzers
- Add of a new analysis handler in UI sending every selected file to the
analyzer.

The current changes are not complete, javadoc and cleaning task should
be realized to use clean files.
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
Note : Tests were commented for UI.
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
Checker attributes are now set on new instance. Javadoc added and the
function applyRules was renamed to check.
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
The analyzer service is now only running only one analysis with check
method. This method is now being run two times in the UI plugin, one for
the metric and a second time for the rules. MetricsViews was updated to
take it in consideration and xml export nows add resultValue attribute
when necessary.
Test were modified to also work with theses modifications
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
Added files extensions to fortran 77 as defined in #28.
Adjusted the Analyzer to handle both situation where the contributor
included the dot before the format extension and not.
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
File in parameter of getCheckResult was useless as in accordance with
the limitation #24, an AbstractChecker is intended only to one file.
WaldoFR pushed a commit that referenced this issue Jul 13, 2017
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Violation and FileValue had both a file attribute which type was IPath.
Changing it into File from java.io.File package imply a lot of little
modifications in files using theses objects.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Last modification of lex files didn't include the removal of unused
import in metrics.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Changelog :
- Removal of the old Analyzer in the Analyzer plugin;
- Removal of the analysis handler in the UI plugin
- Add of an Analyzer plugin runnable from any third using
applyRules(List<File>,List<String>,List<String>) and
computeMetrics(List<File>,List<String>,List<String>) indicating files &
languages to run the analysis on. 
- Analyzer is now responsible to run the appropriate files on the good
analyzers
- Add of a new analysis handler in UI sending every selected file to the
analyzer.

The current changes are not complete, javadoc and cleaning task should
be realized to use clean files.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
Note : Tests were commented for UI.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
…on name

Checker attributes are now set on new instance. Javadoc added and the
function applyRules was renamed to check.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
The analyzer service is now only running only one analysis with check
method. This method is now being run two times in the UI plugin, one for
the metric and a second time for the rules. MetricsViews was updated to
take it in consideration and xml export nows add resultValue attribute
when necessary.
Test were modified to also work with theses modifications
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
…and more.

Added files extensions to fortran 77 as defined in cnescatlab#28.
Adjusted the Analyzer to handle both situation where the contributor
included the dot before the format extension and not.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
File in parameter of getCheckResult was useless as in accordance with
the limitation cnescatlab#24, an AbstractChecker is intended only to one file.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
begarco pushed a commit that referenced this issue Feb 2, 2020
Violation and FileValue had both a file attribute which type was IPath.
Changing it into File from java.io.File package imply a lot of little
modifications in files using theses objects.
begarco pushed a commit that referenced this issue Feb 2, 2020
Last modification of lex files didn't include the removal of unused
import in metrics.
begarco pushed a commit that referenced this issue Feb 2, 2020
Fix #14 & Update #16 using File instead of IPath
begarco pushed a commit that referenced this issue Feb 2, 2020
Changelog :
- Removal of the old Analyzer in the Analyzer plugin;
- Removal of the analysis handler in the UI plugin
- Add of an Analyzer plugin runnable from any third using
applyRules(List<File>,List<String>,List<String>) and
computeMetrics(List<File>,List<String>,List<String>) indicating files &
languages to run the analysis on. 
- Analyzer is now responsible to run the appropriate files on the good
analyzers
- Add of a new analysis handler in UI sending every selected file to the
analyzer.

The current changes are not complete, javadoc and cleaning task should
be realized to use clean files.
begarco pushed a commit that referenced this issue Feb 2, 2020
Note : Tests were commented for UI.
begarco pushed a commit that referenced this issue Feb 2, 2020
Checker attributes are now set on new instance. Javadoc added and the
function applyRules was renamed to check.
begarco pushed a commit that referenced this issue Feb 2, 2020
The analyzer service is now only running only one analysis with check
method. This method is now being run two times in the UI plugin, one for
the metric and a second time for the rules. MetricsViews was updated to
take it in consideration and xml export nows add resultValue attribute
when necessary.
Test were modified to also work with theses modifications
begarco pushed a commit that referenced this issue Feb 2, 2020
Added files extensions to fortran 77 as defined in #28.
Adjusted the Analyzer to handle both situation where the contributor
included the dot before the format extension and not.
begarco pushed a commit that referenced this issue Feb 2, 2020
File in parameter of getCheckResult was useless as in accordance with
the limitation #24, an AbstractChecker is intended only to one file.
begarco pushed a commit that referenced this issue Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants