docs: fixes to create valid RST#32
Merged
mattklein123 merged 2 commits intocncf:mainfrom Mar 14, 2022
Merged
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
phlax
reviewed
Mar 9, 2022
xds/core/v3/collection_entry.proto
Outdated
| // Optional name to describe the inlined resource. Resource names must | ||
| // [a-zA-Z0-9_-\./]+ (TODO(htuch): turn this into a PGV constraint once | ||
| // Optional name to describe the inlined resource. Resource names must match | ||
| // `[a-zA-Z0-9_-\./]+` (TODO(htuch): turn this into a PGV constraint once |
Member
There was a problem hiding this comment.
use double backticks `` for literals in RST - the default with a single backtick is to italicize
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
/assign @markdroth |
Contributor
Author
|
@snowp Can you help this get merged? |
snowp
approved these changes
Mar 14, 2022
Contributor
|
Happy to approve but I think we need @htuch or @markdroth to do the actual merge |
mattklein123
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @phlax
Signed-off-by: Kuat Yessenov kuat@google.com