matchers: add action name as opposed to full configuration#28
Closed
matchers: add action name as opposed to full configuration#28
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
CC @snowp |
Contributor
|
I assume this would work by passing in a map of name to action when invoking the matcher tree? I'm okay with this in principle. @snowp, any concerns? |
Contributor
Author
|
Yes, there is too much boilerplate when using string-valued actions (see the linked PR). Open to other ways but this looked least disruptive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful to reduce verbosity for string-value actions, e.g. picking a listener by name using the unified matchers.
Generally applicable to situations where many leaves are identical in a match tree.
Signed-off-by: Kuat Yessenov kuat@google.com