cmd, pkg, schema: stop using github.com/pkg/errors. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
fixes/deps/github-pkg-errors
branch
2 times, most recently
from
3e9de95 to
1503b67
Compare
klihub
changed the title
klihub
force-pushed
the
fixes/deps/github-pkg-errors
branch
2 times, most recently
from
a5b10d5 to
e86a265
Compare
elezar
reviewed
Nov 11, 2022
| @@ -17,9 +17,9 @@ | |||
| package cdi | |||
|
|
|||
| import ( | |||
| "errors" | |||
There was a problem hiding this comment.
Should we use fmt.Errorf over errors.New for all errors even if no formatting is performed?
There was a problem hiding this comment.
Would there be some real benefit to it ? This errors is golang stdlib (so always present/available by the toolchain) and we anyway depend on it because we use errors.Is() elsewhere in the code.
There was a problem hiding this comment.
Was more of a general question. Not a blocker.
There was a problem hiding this comment.
a related comment is to make the cdi errors hierarchy so that, e.g., goerr113 linter is happy. In particular,
"error should not be created dynamically from scratch but by the wrapping the static (package-level) error."
$ golangci-lint run --disable-all -E goerr113
e86a265 to
ab4d52f
Compare
klihub
changed the title
Get rid of github.com/pkg/errors dependency. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
fixes/deps/github-pkg-errors
branch
from
ab4d52f to
2ce182d
Compare
elezar
reviewed
Nov 15, 2022
klihub
force-pushed
the
fixes/deps/github-pkg-errors
branch
from
2ce182d to
dd57a82
Compare
klihub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of
github.com/pkg/errorsdependency.