pkg/cdi: fix build/vet failures on windows.

[klihub]

Fix two build failures for Windows. One in stock code and another in tests, which show up as a 'go vet' failure. Fix a data read/write race which was probably triggered by the latter Windows fix slightly altering timing in some of tests... or just by sheer luck.

Update the github workflow to run sanity checking (lint, vet) both for Linux and Windows. The checks always run on a Linux distro, but they override GOOS/GOARCH for the toolchain.

Update the github worfklow to do binary test builds/cross-builds both for Linux and Windows.

[bart0sh]

/lgtm

[elezar]

Some minor comments. I think these are generally no-ops and I'd be happy to merge pending feedback.

(would be nice to update the dates in the license strings).

[klihub]

Some minor comments. I think these are generally no-ops and I'd be happy to merge pending feedback.

(would be nice to update the dates in the license strings).

My preference would be to file another PR which removes any explicitly spelled out dates from all file headers and the copyright template (and create it if we don't have yet such a thing separately in the repo). This is similar to how, for instance, containerd deals with this. It removes this class of problem once and for all.

[elezar]

Some minor comments. I think these are generally no-ops and I'd be happy to merge pending feedback.
(would be nice to update the dates in the license strings).

My preference would be to file another PR which removes any explicitly spelled out dates from all file headers and the copyright template (and create it if we don't have yet such a thing separately in the repo). This is similar to how, for instance, containerd deals with this. It removes this class of problem once and for all.

That sounds great.

[elezar]

Thanks @klihub.

Sorry about the back and forth on the minor points.