Add AdditionalGIDs field to ContainerEdits #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
add-additional-guids
branch
from
1cf92d7 to
a57412a
Compare
elezar
force-pushed
the
add-additional-guids
branch
from
a57412a to
3d6c89e
Compare
|
Thanks for the fast review @klihub. Just realizeds that I didn't add a minimum version test. |
Okay. Sorry for not having spotted that either. Let's throw that in and then I'd consider this good to go in. |
klihub
approved these changes
Jan 10, 2024
|
@elezar This needs now a rebase and conflict resolution. |
This change adds an AdditionalGIDs field to the ContainerEdits structure. This allows CDI spec producers to associate a group ID with the container's user to allow access to, for example, device nodes with specific permissions. Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
add-additional-guids
branch
from
3d6c89e to
9ba82ac
Compare
|
Rebased off main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an AdditionalGIDs field to the ContainerEdits structure. This allows CDI spec producers to associate a group ID with the container's user to allow access to, for example, device nodes with specific permissions.
This closes #175