dependencies: update opencontainers packages (rebased #87) #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update runtime-tools contain opencontainers/runtime-tools#755 and thus CDI will have less dependencies when only used to write files without validation. Signed-off-by: Patrick Ohly <[email protected]>
klihub
force-pushed
the
rebased/pohly/container-deps
branch
from
b53abb0 to
292bba6
Compare
elezar
approved these changes
Nov 11, 2022
| @@ -5,8 +5,8 @@ go 1.17 | |||
| require ( | |||
| github.com/fsnotify/fsnotify v1.5.1 | |||
| github.com/opencontainers/runc v1.1.2 | |||
| github.com/opencontainers/runtime-spec v1.0.3-0.20210326190908-1c3f411f0417 | |||
| github.com/opencontainers/runtime-tools v0.0.0-20190417131837-cd1349b7c47e | |||
| github.com/opencontainers/runtime-spec v1.0.3-0.20220825212826-86290f6a00fb | |||
There was a problem hiding this comment.
Question: I don't see v1.0.3 or v0.9.1 tags in these repos. Is this because these are pseudo versions that gomod bumps to the next patch release?
There was a problem hiding this comment.
Runtime tools has been going now for years untagged. We have to hand-pick/lock its version at or past the two commits that prevent the xeipuuv/jsonschema dependencies from always getting pulled in downstream. That sha1 is the tip of that tree. Same story for runtime-spec wrt. tagging. Last tagged one (1.0.2) is from January 2020. We don't need the absolute latest version, but we need newer than 1.0.2. Those pseudo-versions should result those sha1-exact versions being fetched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update runtime-tools contain
opencontainers/runtime-tools#755 and thus CDI will have less dependencies when only used to write files without validation.
Signed-off-by: Patrick Ohly [email protected]