feat: add 'duffle creds edit' #356
Conversation
technosophos
force-pushed
the
feat/245-credentials-edit
branch
2 times, most recently
from
ee4ce05 to
d509068
Compare
Add an editor for editing the credentialsets that exist in your home directory. This delegates all of the heavy lifting to the Survey module, which provides a cross-platform editor feature. Closes #245
technosophos
force-pushed
the
feat/245-credentials-edit
branch
from
d509068 to
29fc504
Compare
| Long: credentialEditDesc, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| edit.home = home.Home(homePath()) | ||
| edit.name = args[0] |
There was a problem hiding this comment.
This should error out if the provided credential name is empty - right now, it simply exits, without any additional information.
There was a problem hiding this comment.
🤦♂️ Ugh... I forgot to set the arg count flag. Thx. I'll fix that.
|
A couple of additional comments regarding the editor used:
However, these issues would have to be fixed upstream, in the survey library, and should not prevent this PR from getting merged. |
|
I can confirm that when I did |
|
Ready for re-review |
| @@ -36,6 +36,7 @@ func newCredentialEditCmd(w io.Writer) *cobra.Command { | |||
| Use: "edit [NAME]", | |||
| Short: "edit an existing credential set", | |||
| Long: credentialEditDesc, | |||
| Args: cobra.ExactArgs(1), | |||
Add an editor for editing the credentialsets that exist in your home directory.
This delegates all of the heavy lifting to the Survey module, which provides a cross-platform editor feature.
Closes #245