Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

duffle.json references #751

Closed
michelleN opened this issue May 13, 2019 · 3 comments · Fixed by #801
Closed

duffle.json references #751

michelleN opened this issue May 13, 2019 · 3 comments · Fixed by #801
Labels
good first issue Good for newcomers

Comments

@michelleN
Copy link
Contributor

In some places duffle.json is referred to as the duffle config file and in other places, it is referred to as the duffle manifest. We should pick one and stick with it across documentation, code and error descriptions.

The floor is now open for naming opinions. 💁

@carolynvs
Copy link
Contributor

carolynvs commented May 13, 2019

For context, porter calls porter.yaml (or any eventual variation) a manifest. Is the bundle.json a manifest? At one point I thought it was but now I'm grepping the spec and in some places it says manifest (mostly in the registry media type) and the rest of the place it doesn't use that.

I had originally called porter's file a manifest because it was porter's representation of the bundle manifest. Now I'm wondering if we goofed?

@technosophos
Copy link
Member

duffle.json is a configuration file that tells Duffle how to build a bundle descriptor and the associated images. It is not a manifest because it is not an enumeration of the constituent parts of a bundle.

@glyn
Copy link
Contributor

glyn commented Jun 11, 2019

Now this is decided, flagging as good first issue.

@glyn glyn added the good first issue Good for newcomers label Jun 11, 2019
benpatt added a commit to benpatt/duffle that referenced this issue Jul 22, 2019
benpatt added a commit to benpatt/duffle that referenced this issue Jul 24, 2019
jeremyrickard pushed a commit that referenced this issue Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants