Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KLeastExecutedFilter and MutationGuidance #79

Merged

Conversation

nicoleraenair
Copy link
Contributor

MutationGuidance.java: The run method was incorrectly counting the number of mutants run for each input.

KLeastExecutedFilter: There was a bug in this that explains most of the evaluation anomalies - the filter was returning a list of k mutants even when fewer than k mutants were in the list to be filtered.

Copy link
Contributor

@rohanpadhye rohanpadhye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

@rohanpadhye rohanpadhye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can you add a unit test to validate the updated logic in KleastExecuted? The test should be something that passes in the new version but will likely fail in the old buggy version.

rohanpadhye
rohanpadhye previously approved these changes Jul 8, 2022
Copy link
Contributor

@rohanpadhye rohanpadhye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the test!

@vasumv vasumv merged commit a6a7876 into main Jul 26, 2023
@vasumv vasumv deleted the nicole/fix-leastexec-filter-and-mutationguidance-run-count branch July 26, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants