Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip classic since outsourced #972

Merged
merged 7 commits into from
Jul 2, 2021
Merged

strip classic since outsourced #972

merged 7 commits into from
Jul 2, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jul 1, 2021

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

removes the classic mode and its tail, since moved to https://github.com/cmu-delphi/www-covidcast-classic

@sgratzl sgratzl self-assigned this Jul 1, 2021
@netlify
Copy link

netlify bot commented Jul 1, 2021 •
edited
Loading

✔️ Preview link ready!

🔨 Explore the source changes: 96f8d5a

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/60df3a19dc7c0600087ef490

😎 Browse the preview: https://deploy-preview-972--cmu-delphi-covidcast.netlify.app

@sgratzl sgratzl changed the title strip classic since outsouces strip classic since outsourced Jul 1, 2021
@sgratzl sgratzl marked this pull request as ready for review July 1, 2021 14:02
@sgratzl sgratzl requested a review from krivard July 1, 2021 14:02
krivard
krivard approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit 9365ff5 into dev Jul 2, 2021
@sgratzl sgratzl deleted the sgratzl/strip-classic branch July 2, 2021 16:12
@krivard krivard mentioned this pull request Jul 9, 2021
Merged
@melange396 melange396 mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees

@sgratzl sgratzl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratzl @krivard