-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add testing environment #604
Conversation
Preview link ready! Built with commit 1cd9d3d https://deploy-preview-604--cmu-delphi-covidcast.netlify.app |
I reviewed the jest and cypress web sites and docs, and it all looks good to me. The main question I would have is whether they work well with Svelte, given it's particular design characteristics. |
for cypress it doesn't make a difference since it is working with the website. for Jest, I use https://testing-library.com/docs/svelte-testing-library/intro which should deal with Svelte characteristics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testing framework here LGTM, but there's a lot to review.
I think I understand the test hooks and writing tests, but I do not understand the changes around msa.csv.js
and friends. Can you summarize?
importing non JavaScript files (like CSV) in JavaScript files usually requires a bundler like webpack or rollup with a custom loader. However, now we also have Jest in the loop which compiles the test code and thus also needs to handle to those kind of imports files. To avoid a more complicated test setup, I wrapped the CSV files to JavaScript modules, similar to what the current raw-loader of webpack was doing before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable. LGTM, thanks for the work here.
Prerequisites:
dev
branchdev
Summary
usage -> see README section