Skip to content

tools/terrier_bench: call TxnCommitted() only after Commit() in Bench2TaskTransfer #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tools/terrier_bench: call TxnCommitted() only after Commit() in Bench2TaskTransfer #843

wants to merge 1 commit into from

Conversation

alterego655
Copy link

  • Bench2TaskTransfer() calls metrics.TxnCommitted() before txn_manager_->Commit(txn) and again after it, which double-counts on success and miscounts on failure.
  • This pr removes the early call so metrics reflect only successfully committed transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alterego655