Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RP2350 SVD #8

Closed
wants to merge 11 commits into from
Closed

Added RP2350 SVD #8

wants to merge 11 commits into from

Conversation

AverseABFun
Copy link
Contributor

@AverseABFun AverseABFun commented Aug 8, 2024

First contribution, got SVD from here.
The RP2350 is a newly released MCU from Raspberry Pi, released along side the Raspberry Pi Pico 2.

Copy link
Contributor

@deadprogram deadprogram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AverseABFun
Copy link
Contributor Author

Hey! @VincentDary could you outline why this was closed without merging?

@VincentDary
Copy link
Member

This is an error on my part, I am working on the issue 4 and I have force push on the repository, the issue has been closed automatically, I can't reopen the issue, Github block the reopen buton, but I am working to merge your commit and other closed automatically.

@BenBE
Copy link
Collaborator

BenBE commented Oct 26, 2024

@AverseABFun I have a branch with your commits prepared on my fork. They aren't lost. It just got too late yesterday while investigating the situation. Once the mentioned issue #4 has been resolved, we'll work on merging #5, #6, #7, #9 and this one, which were all affected. Issue #10 will receive a replacement with another implementation though (working on that one too).

@AverseABFun
Copy link
Contributor Author

Alright, sounds good! Thanks for informing me.

@VincentDary
Copy link
Member

SVD file contribution verified against original file provider, OK.

$ git clone https://github.com/raspberrypi/pico-sdk.git
$ cd pico-sdk/src/rp2350/hardware_regs/
$ sha512sum RP2350.svd > ../../../../hash_from_raspberrypi.txt
$ cd ../../../../
$ sed -i -e 's/RP2350.svd/rp2350.svd/g' hash_from_raspberrypi.txt
$ git clone https://github.com/BenBE/cmsis-svd-data.git
$ cd cmsis-svd-data
$ git checkout rp2350
$ cd data/RaspberryPi
$ sha512sum -c ../../../hash_from_raspberrypi.txt
rp2350.svd: OK
$ echo $?
0

@AverseABFun thank you very much for your contribution.

hash_from_raspberrypi.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants