Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull new translations and add script to map files #1309

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

wil93
Copy link
Member

@wil93 wil93 commented Dec 23, 2024

There might be some string deletions, this is probably because the source text was changed and thus OneSky refused to import those translations so they are lost now. We could fix this manually, but it's probably easier to just wait until translators will fix it on Onesky.

@wil93 wil93 requested a review from veluca93 December 23, 2024 22:41
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@7897696). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
copy_translations.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1309   +/-   ##
=========================================
  Coverage          ?   67.98%           
=========================================
  Files             ?      332           
  Lines             ?    26557           
  Branches          ?        0           
=========================================
  Hits              ?    18054           
  Misses            ?     8503           
  Partials          ?        0           
Flag Coverage Δ
functionaltests 45.91% <ø> (?)
unittests 55.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wil93 wil93 force-pushed the update_translations branch from 1e95904 to c7d5bfa Compare December 23, 2024 22:49
@wil93 wil93 force-pushed the update_translations branch from c7d5bfa to 3a48b7a Compare December 23, 2024 22:55
Add script to map downloaded translations to CMS ones
@wil93 wil93 force-pushed the update_translations branch from 3a48b7a to bb9312a Compare December 23, 2024 22:55
@wil93 wil93 merged commit 8c0ff79 into cms-dev:master Dec 23, 2024
3 checks passed
@wil93 wil93 deleted the update_translations branch December 24, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants