returns "changed" when no change made

[Lx]

Given XML in file.xml:

<a>
  <b>
    <c>D</c>
  </b>
</a>

the following Ansible task:

- name: ensure D
    xml: file=file.xml xpath=/a/b/c value=D
    notify: restart the thing

always returns as changed, even when no change was made, resulting in handlers being triggered when not necessary.

[cmprescott]

+1 I noticed this too. I was going to put together a PR, but didn't seem worth it until interest in repo picks up again.

PS @Lx --- I read something on SO about how to get the eye of dead github repo's. However, I think that was back when you could message people on github. But anyways if anyone with write access is reading this. I would be happy to take over this repo.

[Lx]

@tbielawa and @relaxnow (the two main contributors to this repository) have both pushed commits to other GitHub projects in the past week, so they may be able to give you an answer on whether or not transfer of ownership would be permissible.

Even if not, I'd be happy to run off any fork that addresses the issues I've raised here (#12, #13, #14, #15).

[tbielawa]

Oh hi folks. We're looking pass this on. If someone wanted to own the task of fixing up the module and taking ownership going forward that'd be great. Bonus points if you can work it into the ansible-modules-extra proper repo. I'll come back tomorrow and write up a more formal idea of what I'm talking about!

Thanks @Lx and @cmprescott for getting my attention on this.

[tbielawa]

@Lx @cmprescott please take a minute to review #16 (ansible-xml needs new care takers) if you can

:)

[cmprescott]

@Lx Do you mind testing https://github.com/cmprescott/ansible-xml/tree/feature/%2312_Idempotent to see if it fixes this issue in your use case? It fixed mine, but I would like a second set of eyes on it.

[Lx]

Works well for me on my setup. Thanks!

[cmprescott]

Awesome. I'm going to create a PR and merge in today.