4xx response body is null

[ngot]

Issue

Setup:

• deno 1.0.5
• v8 8.4.300
• typescript 3.9.2

4xx response body is null, even though there is a response body.

Details

I want to test the custom response body, but there is nothing in res body.

By the way, when responding 4xx, superdeno also throws error which is different from supertest, which is annoying.

[asos-craigmorten]

Hmm, this is actually an issue that has impacted supertest on several occasions, see:

• expect(!2xx) throws exception ladjs/supertest#556
• supertest 4.x.x throws if not HTTP/200 ladjs/supertest#559

And is generally as a result of the underlying superagent library having an issue, e.g.:

• Regression in v4: expect(404) treats status code 404 as an error ladjs/superagent#1466

It looks like we're using a later version of sugeragent than supertest is, when I next have time I'll see if matching the versions (i.e. a downgrade) solves it. Given this library almost exactly mirrors how supertest works I suspect it is likely the dependency, but it may be a nuance that was missed in porting it over.

Do you have a minimal reproducible code example that can be used (e.g. server and test you're trying to run)?

Alternatively, please feel free to investigate and try and tackle the issue! PRs are welcome 😄

[ngot]

It can be reproduced by:

import {
  Application,
} from "https://deno.land/x/ako/mod.ts";
import { superdeno } from "https://deno.land/x/[email protected]/mod.ts";
import { describe, it } from "https://deno.land/x/[email protected]/test/utils.ts";
import {
  assert,
  assertEquals,
} from "https://deno.land/[email protected]/testing/asserts.ts";

describe("ctx.onerror(err)", () => {
  it("should respond", (done) => {
    const app = new Application();

    app.use((ctx, next) => {
      ctx.body = "something else";

      ctx.throw(418, "boom");
    });

    const server = app.listen();

    superdeno(server)
      .head("/")
      .expect(418)
      .expect("Content-Length", "4")
      .expect("Content-Type", "text/plain; charset=utf-8")
      .end((err, res) => {
        assertEquals(err.message, "I'm a teapot");
        assertEquals(res.status, 418);
        // TODO: https://github.com/asos-craigmorten/superdeno/issues/1
        // assertEquals(res.text, "boom");
        done();
      });
  });
});

According to ladjs/superagent#1468, seems like it was fixed. I will try to fix it this week sometime.

[asos-craigmorten]

Taking a look at this. Added a simple unit test for .expect(400) and seeing:

error: Uncaught Error: Bad Request
          new_err = new Error(res.statusText || res.text || 'Unsuccessful HTTP response');
                    ^
    at Test.<anonymous> (https://dev.jspm.io/npm:[email protected]/lib/client.dew.js:475:21)
    at Test.Emitter.emit (https://dev.jspm.io/npm:[email protected]/index.dew.js:148:22)
    at XMLHttpRequestSham.xhr.onreadystatechange (https://dev.jspm.io/npm:[email protected]/lib/client.dew.js:784:12)
    at XMLHttpRequestSham.xhrReceive (~/git/asos-craigmorten/superdeno/src/xhrSham.js:105:29)
    at ~/git/asos-craigmorten/superdeno/src/xhrSham.js:52:21
    at Object.xhr.onreadystatechange (~/git/asos-craigmorten/superdeno/src/xhrSham.js:186:7)
    at XMLHttpRequestSham.xhrSend (~/git/asos-craigmorten/superdeno/src/xhrSham.js:287:9)
    at async XMLHttpRequestSham.send (~/git/asos-craigmorten/superdeno/src/xhrSham.js:51:7)

The referenced line is here --> https://github.com/visionmedia/superagent/blob/master/src/client.js#L468

Introduced in ladjs/superagent#1473

---

I can confirm that isn't an issue with latest supertest having tried to reproduce with:

const express = require("express");
const request = require("supertest");

const app = express();

app.get("/", (req, res, next) => {
  res.sendStatus(400);
});

request(app)
  .get("/")
  .expect(400)
  .end((err, res) => {
    if (err) throw err;
  });

So it is something different with SuperDeno. The version of superagent is different, so going to try downgrading to 5.1.0 to match supertest.

[asos-craigmorten]

Thanks for raising this @ngot 😄 found the bug and should be fixed in latest version! 🎉

[asos-craigmorten]

Let me know if still encountering any issues!