test(cli): assert exact fallback value in _get_current_version test

[cmeans-claude-dev]

Summary

Tighten `TestVersionHelpers::test_get_current_version_falls_back_on_metadata_failure` from `isinstance(_get_current_version(), str)` to `_get_current_version() == cli_mod.version`. The old assertion passed for any string — it would not catch a regression that silently returned `"error"`, `""`, or any other value from the fallback branch.

Matches the shape already adopted in `tests/test_config.py::TestResolveVersion::test_falls_back_to_0_0_0_when_metadata_unavailable`, consistent with PR #30's "the number should mean what it claims" philosophy.

Closes #32.

Test plan

• `.venv/bin/python -m pytest tests/test_cli.py::TestVersionHelpers -v` — all 6 pass.
• `.venv/bin/python -m pytest tests/ -q` — 449 passed.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[cmeans]

QA Review — PR #35

Verdict: QA Failed

One substantive finding blocks signoff (missing CHANGELOG entry). The test tightening itself is correct and matches issue #32 exactly.

Verification

• Diff is exactly scoped to the issue: tests/test_cli.py +2/-1 — adds the cli_mod import and replaces isinstance(..., str) with == cli_mod.__version__. Nothing else touched.
• Fallback contract is tested meaningfully now. monkeypatch.setattr(importlib.metadata, "version", boom) forces the except branch in _get_current_version() at src/yt_dont_recommend/cli.py:49. That branch is documented to return __version__, which is re-imported into cli.py from config.py:88 (__version__: str = _resolve_version()). Asserting equality with cli_mod.__version__ means a regression like return "error" or return "" would now fail the test — whereas the old isinstance(..., str) passed for any string.
• Mirrors the analogous tightening in tests/test_config.py::TestResolveVersion::test_falls_back_to_0_0_0_when_metadata_unavailable (asserts exact "0.0.0"), which was the precedent called out in issue #32. Philosophy consistency looks good.
• Tests — tests/test_cli.py::TestVersionHelpers → 6/6 PASSED in 0.08s; full suite → 449 passed in 33.97s. Both match the PR body.
• CI all required checks green on test/cli-version-fallback-exact-value.

Findings

#	Finding	Severity
1	No CHANGELOG.md ## [Unreleased] entry for this PR. Project convention is that every PR — test-only included — adds an Unreleased entry, and new tests go under ### Added. The existing ### Added — Test coverage push to 100% on pure-logic modules entry describes PR #30's bulk coverage work, not this follow-on tightening of the _get_current_version fallback assertion (closes #32). Suggested: add a ### Added entry along the lines of "Tightened TestVersionHelpers::test_get_current_version_falls_back_on_metadata_failure from isinstance(str) to equality with cli.__version__, mirroring the exact-value assertion already used for _resolve_version's "0.0.0" fallback in TestResolveVersion (closes #32)."	substantive

Notes

• No observations / nits beyond the CHANGELOG gap.
• Once the Unreleased entry lands, I'd re-run tests/test_cli.py::TestVersionHelpers -v + full suite on the refreshed branch and promote to Ready for QA Signoff assuming no regressions.

[cmeans]

LGTM

[cmeans]

QA Review — Round 2 on PR #35

Verdict: Ready for QA Signoff

Round-1 finding addressed; re-verification clean.

Re-verification

• CHANGELOG ## [Unreleased] → ### Added entry added — closes #32, explains the weaken-to-strict motivation and cross-references the TestResolveVersion precedent. Correct section and category for a test addition.
• Test diff unchanged from round 1 (still +2/-1 in tests/test_cli.py) — assert _get_current_version() == cli_mod.__version__ is the documented fallback contract; would fail if a regression changed the except branch to return anything other than cli.__version__.
• Tests: tests/test_cli.py::TestVersionHelpers -v → 6/6 PASSED in 0.08s. Full suite → 449 passed in 33.96s.
• Lint: .venv/bin/ruff check src/ tests/ → all checks passed.
• CI green on the refreshed branch; mergeable.

Promoting to Ready for QA Signoff. Maintainer can apply QA Approved.