Add /favicon.ico route for connector icon

[cmeans]

Merge order: Depends on #82 (label automation) and #80 (license change) merging first. Rebase onto main after both land.

Summary

• Serve the awareness logo at /favicon.ico from both ASGI middleware classes
• Anthropic's Connectors UI uses Google's favicon service to display connector icons — this replaces the generic globe with the awareness eye logo
• Route is public (served before secret path check) so external crawlers can reach it
• favicon.ico included in the wheel via force-include in pyproject.toml

QA

Prerequisites

• pip install -e ".[dev]"
• Deploy to test instance on alternate port (AWARENESS_PORT=8421)

Manual tests (via HTTP — middleware routes, not MCP tools)

1. • Favicon on secret-path deployment

   curl -sI https://<test-host>/favicon.ico
   

   Expected: HTTP 200, Content-Type: image/x-icon, ~15KB body

2. • Favicon does NOT require secret path

   curl -sI https://<test-host>/favicon.ico
   

   Expected: Returns 200 even though other non-secret paths return 404

3. • Health endpoint still works

   curl -s https://<test-host>/<secret>/health
   

   Expected: JSON with status "ok"

4. • MCP endpoint unaffected
     Verify get_briefing still works via MCP client
5. • Tests pass locally

   python -m pytest tests/test_middleware.py -v
   

   Expected: 15 tests pass (was 13, +2 favicon tests)

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[cmeans]

Adding Awaiting CI — blocked on #82 and #80 merging first (merge-order: 3). Will rebase and get fresh CI once both land.

[cmeans]

Needs rebase after #80 merges. Holding until then.

[cmeans]

CI green after rebase. Ready for QA. (Manual promotion — force push breaks workflow_run PR lookup.)

[cmeans]

QA Review — PR #81: Add /favicon.ico route for connector icon

Code Review

• Favicon loaded at import time (_FAVICON_BYTES) — efficient, no repeated disk I/O. Graceful None fallback if file missing.
• Both middleware classes serve /favicon.ico — SecretPathMiddleware serves before secret check (correct for public route), HealthMiddleware serves alongside /health.
• HealthMiddleware refactored to nested if within scope["type"] == "http" — clean, no logic change for existing /health behavior.
• pyproject.toml force-include mirrors existing instructions.md pattern.
• Response uses image/x-icon content type — correct for .ico files.
• AGPL header present on modified middleware.py (pre-existing from #80).

Test Results

Check	Result
test_middleware.py — 15 tests	✅ (was 13, +2 favicon)
Full suite — 383 tests	✅ (was 381, +2 favicon)
ruff	✅ (via CI)
mypy	✅ (via CI)
codecov/patch	✅

Manual Tests

#	Test	Result
1	Favicon served — HTTP 200, image/x-icon, 15,086 bytes	✅
2	Favicon served without secret path	✅ (tested on HealthMiddleware instance)
3	Health endpoint still works — {"status":"ok"}	✅
4	MCP endpoint unaffected — get_briefing works	✅ (production instance verified via awareness MCP)
5	test_middleware.py — 15/15 pass	✅

Verdict

Zero findings. Clean, focused PR. All 5 manual tests pass, 383/383 automated tests pass. Ready for signoff.

[cmeans]

Adding Ready for QA Signoff — all 5 manual tests pass, 383/383 automated tests (15/15 middleware), CI green, zero findings. Removing Ready for QA.

[cmeans]

LGTM