fix: replace em dash with ASCII in session SQL comment#172
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cmeans
reviewed
Apr 8, 2026
Owner
cmeans
left a comment
There was a problem hiding this comment.
QA Review
Replaces Unicode em dash with ASCII double-dash in SQL comment — avoids potential encoding issues with some Postgres clients/locales. CI green.
Zero findings. Verdict: Pass.
Owner
|
Applying Ready for QA Signoff — one-character fix, CI green, zero findings. |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
awareness_sessionsdatabase was created with SQL_ASCII encoding. The em dash (—) in a SQL comment causedUnicodeEncodeErroron startup. Replaced with--.QA
One-character fix in a SQL comment. No behavioral change.