Skip to content

fix: replace em dash with ASCII in session SQL comment#172

Merged
cmeans-claude-dev[bot] merged 1 commit into
mainfrom
fix/sql-unicode
Apr 8, 2026
Merged

fix: replace em dash with ASCII in session SQL comment#172
cmeans-claude-dev[bot] merged 1 commit into
mainfrom
fix/sql-unicode

Conversation

@cmeans-claude-dev
Copy link
Copy Markdown
Contributor

Summary

The awareness_sessions database was created with SQL_ASCII encoding. The em dash () in a SQL comment caused UnicodeEncodeError on startup. Replaced with --.

QA

One-character fix in a SQL comment. No behavioral change.

@github-actions github-actions Bot added the Awaiting CI Dev complete, waiting for CI/Codecov to pass before QA label Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot added Ready for QA Dev work complete — QA can begin review and removed Awaiting CI Dev complete, waiting for CI/Codecov to pass before QA labels Apr 8, 2026
@cmeans cmeans added QA Active QA is actively reviewing; Dev should not push changes and removed Ready for QA Dev work complete — QA can begin review labels Apr 8, 2026
Copy link
Copy Markdown
Owner

@cmeans cmeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Review

Replaces Unicode em dash with ASCII double-dash in SQL comment — avoids potential encoding issues with some Postgres clients/locales. CI green.

Zero findings. Verdict: Pass.

@cmeans cmeans added Ready for QA Signoff QA passed — ready for maintainer final review and merge and removed QA Active QA is actively reviewing; Dev should not push changes labels Apr 8, 2026
@cmeans
Copy link
Copy Markdown
Owner

cmeans commented Apr 8, 2026

Applying Ready for QA Signoff — one-character fix, CI green, zero findings.

Copy link
Copy Markdown
Owner

@cmeans cmeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmeans cmeans added QA Approved Manual QA testing completed and passed and removed Ready for QA Signoff QA passed — ready for maintainer final review and merge labels Apr 8, 2026
@cmeans-claude-dev cmeans-claude-dev Bot merged commit 4e4c6b6 into main Apr 8, 2026
35 checks passed
@cmeans-claude-dev cmeans-claude-dev Bot deleted the fix/sql-unicode branch April 8, 2026 17:04
@cmeans cmeans mentioned this pull request Apr 9, 2026
@cmeans-claude-dev cmeans-claude-dev Bot mentioned this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Approved Manual QA testing completed and passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant