git and Posh-git check #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly call `import posh-git` because it doesn't have a module manifest thus powershell can't autoload it when using a cmdlet. At present the cmder repo doesn't try to download posh-git so it might be missing from the users session.
In an effort to speed up the prompt we will only call write-vcsstatus if there is a .git folder in the current or any parent path recursively. As this function is called every new prompt line it needs to be as fast as possible.
| $gitStatus = $false | ||
| } | ||
|
|
||
| function checkGit($Path) { |
There was a problem hiding this comment.
@Jackbennett @MartiUK
I don't understand the reason of this function. Posh-Git checks himself what you write, isn't it?
There was a problem hiding this comment.
I pulled out the code that imported everything all the time from our vendor\psmodules in another commit (e811c60)
Posh-git needs a module manifest creating to behave with powershell's auto-loading behaviour. This checks if we have git and need the cmdlet only if we're actually in a git repository.
All in the name of speed. You don't need to wait for all the git stuff constantly especially if its not even used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't think this looked right so I added some work to it. Somewhere in the build we need to
install-module posh-gitand put it in thevendor/path. That will save us adding posh-git to the repo.See the commit messages for more info I tried to be quite clear.