Unable to run in Windows XP if path contains spaces

[galli-a]

On Windows XP, the Cmder.bat file cannot be executed if the full path contains spaces. It does run succesfully if executed on a path without spaces.

[ghost]

I ran into the same issue on my Windows 7 machine. I have a fix in a local fork, and will be submitting a pull request shortly.

Update: I see an open pull request (#65) from @kjerk which makes all the changes I had in my own fork. I believe if that pull request is accepted, your issue should be resolved.

[ezuk]

I believe this should not be tagged "legacy" because I have this exact issue with Windows 8.1.

[samvasko]

I am packing v1.1.2 now and in about hour you can check that out. It should be fixed with new launcher

[ezuk]

@Bliker - tested 1.1.2, new cmder.exe launcher complains about lack of MSVCP120.dll, won't start.

[samvasko]

Oh damn, thanks, I guess there is a need to distribute that also.

[galli-a]

Tested v1.1.2 as well, the launcher is not recognized as a valid Win32 application.

[samvasko]

I managed to get a quick intro windows .dll files: does this work for you? Please say yes :-D

[galli-a]

I am sorry, but at work I cannot access Dropbox, so I cannot download the files. At home I use OS X, so the best I can do is download from home and test the new release tomorrow. I'll let you know.

[galli-a]

As a piece of good news, I finally was able to make the previous release, v1.1, to run from a path with spaces.
I had to modify both the Cmder.bat and init.bat files. The trick was to modify the construction of the internal paths, with additional escapes.
The modification to Cmder.bat was:

@set CMDER_PATH="%~dp0"
@pushd %CMDER_PATH%
@set CMDER_ROOT=%cd%
@popd

and the one to init.bat

@set rootPath="%~dp0"
@pushd %rootPath%
@pushd ".."
@set rootDir=%cd%
@popd
@popd

Now, if it wasn't for the missing prompt, and the fact that clink crashes, it would be perfect...

[ezuk]

Actually, it kind of works! :) A vast improvement. The app starts without
complaining now. The only immediate issue I have is that after each and
every command, I get "The system cannot find the path specified."

The command executes, but it looks like something's wonky with the path env
var. I'm not totally sure it's even cmder's fault - I get the same error
when first starting cmd.exe in a normal console window, but then I get it
just once.

On 11 December 2013 14:00, Samuel Vasko [email protected] wrote:

I managed to get a quick intro windows .dll files: does this work for you?https://dl.dropboxusercontent.com/u/52646091/cmder_mini.zipPlease say yes :-D

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-30314662
.

[samvasko]

can you type path and paste the output here? Thanks

[ezuk]

λ path

PATH=D:\My Files\Created\Today\cmder
test\vendor\conemu-maximus5\ConEmu;D:\My Files\Created\Today\cmder test\ve
ndor\conemu-maximus5;C:\Program Files (x86)\NVIDIA
Corporation\PhysX\Common;C:\Python33;C:\Program Files (x86)
\ImageMagick-6.8.7-Q16;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPower
Shell\v1.0;C:\Program Files
(x86)\Kensington\TrackballWorks;C:\HashiCorp\Vagrant\bin;C:\Program Files
(x86)\Wi
ndows Live\Shared;C:\Python27;C:\Python27\Scripts;C:\Program Files
(x86)\Git\cmd;D:\My Files\Created\Today\cmde
r test\bin;D:\My Files\Created\Today\cmder test\vendor\msysgit\bin;D:\My
Files\Created\Today\cmder test\vendor
msysgit\mingw\bin;D:\My Files\Created\Today\cmder
test\vendor\msysgit\cmd;D:\My Files\Created\Today\cmder test
vendor\msysgit\share\vim\vim73;

The system cannot find the path specified.

On 11 December 2013 17:18, Samuel Vasko [email protected] wrote:

can you type path and paste the output here? Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-30328444
.

[galli-a]

Tested the version downloaded from Dropbox. Again the launcher is not recognized as a valid Win32 application.

[samvasko]

@galli-a That is rather strange, can you give me your computer specs and md5 (or sha) of the .exe? Thanks

[samvasko]

mine is md5: 8d073afa242dfa7d018a16a3a010a00a from the last release

[galli-a]

The md5 I get is c97c1ebef2ae8bcda933b460687d1ccd from the archive @Bliker uploaded on dropbox (cmder_mni.zip).
The launcher only has 8d073afa242dfa7d018a16a3a010a00a, that matches yours.

I tested both on a Windows XP 32bit with SP3 (Intel core i5), and on a Windows XP Professional x64 (Intel Xeon), and on both I get the same error: is not a valid Win32 application.
This occours regardless of the presence of spaces in the full path.

[samvasko]

I think WIndows XP is the critical part. I will take a look.

[pikzen]

Nope, having the same trouble on Windows 7 x64.

I tried running cmder from different directories :

C:\Program Files\cmder\ causes an error because of the space in "Program Files"
C:\GOG Games\cmder\ causes an error because of the space in "GOG Games"
C:\Windows\cmder\ runs
C:\Windows\cmder space\ runs

%PATH% :
λ echo %PATH%
C:\Program Files (x86)\MacType\;C:\Windows\cmder\vendor\conemu-maximus5\ConEmu;C:\Windows\cmder\vendor\conemu-maximus5;C:\Windows\;C:\Windows\System32\;C:\Program Files (x86)\MacType;C:\Windows\cmder\bin;C:\Windows\cmder\vendor\msysgit\bin;C:\Windows\cmder\vendor\msysgit\mingw\bin;C:\Windows\cmder\vendor\msysgit\cmd;C:\Windows\cmder\vendor\msysgit\share\vim\vim73;;C:\Windows\System32\WindowsPowerShell\v1.0;C:\chocolatey\bin

So, it appears that only the first folder causes trouble. Any spaces after that are OK.

[ezuk]

@Bliker - for me it works fine now, the path error message had nothing to do with Cmder.

Are you going to link to 1.1.2 from the Cmder homepage? Or is it not considered ready yet? (Asking because am considering a possible review.)

[galli-a]

I'd agree with @Bliker, the issue is on Windows XP. I got access to a Windows 7 machine, and tested there. It works fine, regardless of spaces in the path to the launcher.

[samvasko]

@ezuk I was waiting for confirmation about new launcher and dependencies. All seems to be clear right now. So in a few days...