prompt is Garbled

[zydxhs]

As shown below：

cmder ver is 1.3 in win7 64bit。

[jankatins]

Seems that the replacement code can't handle non-ascii chars?

c:\temp
λ mkdir ü

c:\temp
λ cd ü

c:\temp\�
λ

It works fine in a plain cmd window:

c:\temp\ü>

[jankatins]

We currently do this:

    cwd = clink.get_cwd()
    prompt = "\x1b[1;32;40m{cwd} {git}{hg} \n\x1b[1;30;40m{lamb} \x1b[0m"
    new_value = string.gsub(prompt, "{cwd}", cwd)
    clink.prompt.value = string.gsub(new_value, "{lamb}", "λ")

So my reading is that we can't pass the output of clink.get_cwd() to clink.prompt.value?

CC: @mridgers (clink maintainer)

[zydxhs]

May be the clink does not support non-ascii.

[jankatins]

I think it does (letting the cmd set the prompt and then handling it in clink works...), just that the string has to get encoded... No idea how that works :-/

[jankatins]

So, a bit of debugging (to a ANSI encoded file) shows this:

cwd(string): c:\temp\ü
prompt(string): c:\temp\ü> # before any changes in lua
prompt(string): �[1;32;40mc:\temp\ü {git}{hg}  # after changes in lua

If I interpete http://stackoverflow.com/a/14981670/1380673 and the unicode code points right, then
[updated]

• the prompt is utf and probably need to set encoded unicode (ü interpreted as windows1252 is encoded as c3 bc, which translates to ü when interpreted as a unicode codepoint)
• get_cwd() returns the path in windows-125x variants (at least it seems so on my system)

[Note, I have changed my codepage to utf8: chcp 65001 but the same debug output happens with chcp 850 which is the default in a regular cmd window]

So this looks like a problem in clink :-(

[jankatins]

I've taken that upstream: mridgers/clink#415

[zydxhs]

Directly set value to "clink.prompt.value" is ok:
clink.prompt.value = clink.get_cwd

So, I think the problem is happened in the lua script fun string.gsub.

[jankatins]

I can't reproduce: on my system with clink.prompt.value = clink.get_cwd() (not the last ()!) exactly the same happens:

c:\temp\�

[jankatins]

Please try #1070 for a version which parses the original prompt.

[zydxhs]

I also do not know why.

tks for your efforts(#1070), and it's ok in my system.

2016-08-10

johnsmithcry

发件人：Jan Schulz [email protected]
发送时间：2016-08-09 18:47
主题：Re: [cmderdev/cmder] prompt is Garbled (#1054)
收件人："cmderdev/cmder"[email protected]
抄送："zydxhs"[email protected],"Author"[email protected]

I can't reproduce: on my system with clink.prompt.value = clink.get_cwd() (not the last ()!) exactly the same happens:
c:\temp\�

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[jing2si]

good job!Thx~
it fixed my same problem!

[davpaez]

According to this commit in clink, the encoding problem appears to have been fixed.

If so, should the clink.lua script go back to use the clink.get_cwd() inside the set_prompt_filter() function again, instead of relying on the more convoluted parsing of clink.prompt.value?