Skip to content

Fix SPIRV validation: use array ptr for cooperative vector ops #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmarcelo merged 1 commit into from
Mar 31, 2026
Merged

Fix SPIRV validation: use array ptr for cooperative vector ops #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion source/slang/slang-emit-cuda.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,6 @@ bool CUDASourceEmitter::tryEmitInstStmtImpl(IRInst* inst)
}
case kIROp_CoopVecMatMulAdd:
{
auto coopVecMatMulAdd = cast<IRCoopVecMatMulAdd>(inst);
if (!isOptixCoopVec)
{
getSink()->diagnose(Diagnostics::UnsupportedTargetIntrinsic{
Expand Down
52 changes: 45 additions & 7 deletions source/slang/slang-emit-spirv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8313,6 +8313,41 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex
return result;
}

// Emit an operand that satisfies cooperative vector SPIRV opcodes, which require a pointer
// to an array type (not a pointer to a struct).
//
// - Buffer resource case (ByteAddressBuffer / StructuredBuffer): after SPIRV legalization
// the global param has type ptr-to-struct{runtimeArray<T>}. Emit an OpAccessChain with
// index 0 to pierce through the wrapper struct and expose the runtime array.
//
// - Ptr<T[]> case: the pointer already points directly to the unsized array, so return it
// as-is.
SpvInst* emitBufferPtrAsArrayPtr(SpvInstParent* parent, IRInst* bufferVal)
{
IRBuilder builder(bufferVal);
auto addressSpace =
isSpirv14OrLater() ? AddressSpace::StorageBuffer : AddressSpace::Uniform;
IRPtrTypeBase* bufPtrType = cast<IRPtrTypeBase>(bufferVal->getDataType());
// If the pointee is not a struct, the pointer already targets an array directly
// (e.g. Ptr<T[]>) — use it without modification.
IRStructType* bufType = as<IRStructType>(bufPtrType->getValueType());
if (!bufType)
return ensureInst(bufferVal);
// The struct's first (and only) field is the runtime array of elements.
IRArrayTypeBase* arrayType =
cast<IRArrayTypeBase>(bufType->getFields().getFirst()->getFieldType());
return emitOpAccessChain(
parent,
nullptr,
builder.getPtrType(
arrayType,
AccessQualifier::ReadWrite,
addressSpace,
bufPtrType->getDataLayout()),
bufferVal,
makeArray(emitIntConstant(0, builder.getIntType())));
}

SpvInst* emitGetBufferPtr(SpvInstParent* parent, IRInst* inst)
{
IRBuilder builder(inst);
Expand Down Expand Up @@ -9194,12 +9229,12 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex
emitMappedCoopVecComponentTypeOperand(
coopVecMatMulAdd->getInputInterpretation(),
coopVecMatMulAdd->getInputInterpretationPackingFactor());
emitOperand(coopVecMatMulAdd->getMatrixPtr());
emitOperand(emitBufferPtrAsArrayPtr(parent, coopVecMatMulAdd->getMatrixPtr()));
emitOperand(coopVecMatMulAdd->getMatrixOffset());
emitMappedCoopVecComponentTypeOperand(coopVecMatMulAdd->getMatrixInterpretation());
if (hasBias)
{
emitOperand(coopVecMatMulAdd->getBiasPtr());
emitOperand(emitBufferPtrAsArrayPtr(parent, coopVecMatMulAdd->getBiasPtr()));
emitOperand(coopVecMatMulAdd->getBiasOffset());
emitMappedCoopVecComponentTypeOperand(
coopVecMatMulAdd->getBiasInterpretation());
Expand Down Expand Up @@ -9229,7 +9264,7 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex
SpvOpCooperativeVectorOuterProductAccumulateNV,
[&]()
{
emitOperand(outerProduct->getMatrixPtr());
emitOperand(emitBufferPtrAsArrayPtr(parent, outerProduct->getMatrixPtr()));
emitOperand(outerProduct->getMatrixOffset());
emitOperand(outerProduct->getA());
emitOperand(outerProduct->getB());
Expand All @@ -9246,13 +9281,16 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex

auto reduceSum = cast<IRCoopVecReduceSumAccumulate>(inst);

return emitInst(
return emitInstCustomOperandFunc(
parent,
inst,
SpvOpCooperativeVectorReduceSumAccumulateNV,
reduceSum->getBufferPtr(),
reduceSum->getOffset(),
reduceSum->getValue());
[&]()
{
emitOperand(emitBufferPtrAsArrayPtr(parent, reduceSum->getBufferPtr()));
emitOperand(reduceSum->getOffset());
emitOperand(reduceSum->getValue());
});
}

SpvInst* emitSplat(SpvInstParent* parent, IRInst* inst, IRInst* scalar, IRIntegerValue numElems)
Expand Down